Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment, gnome3, mate: fix XDG_MENU_PREFIX #33037

Merged
merged 3 commits into from Dec 25, 2017
Merged

enlightenment, gnome3, mate: fix XDG_MENU_PREFIX #33037

merged 3 commits into from Dec 25, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 24, 2017

Motivation for this change

The environment variable XDG_MENU_PREFIX is documented on the Desktop Menu Specification.

Its value is missing an - at the end, and the enlightenment one should be e-.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar approved these changes Dec 24, 2017
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GNOME, the menus are stored in ${gnome3.gnome-menus}/etc/xdg/menus/gnome-applications.menu (not sure if it is actually used) and I did not find any mentions without the dash, changing the prefix should therefore be fine. Unless someone actually uses such file in their profile, but then I would expect a bug report for this.

@jtojnar jtojnar merged commit 6e0387a into NixOS:master Dec 25, 2017
@romildo romildo deleted the fix.desktop branch December 25, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @jtojnar @GrahamcOfBorg