ghc prebuilt: Add 7.8.4, 7.10.3 and 8.2.1, and make consistent style #33054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes do break hashes, but are good to have everywhere for consistency. Plus, changing the bootstrap causes a Haskell mass rebuild anyways.
The newer to-be-added binaries have relative RPATHs that we'll break if we try to `patchelf` before installation. We instead us LD_LOAD_LIBRARY during the installation, which avoids needing to change the RPATH temporarily.
- Patch all executables and libraries, while skipping scripts. Base at least uses libiconv, so should need this too---I suspect it wasn't a problem before as we got away with the immpurity. - Rather than hardcoding the symlinks to add, do one per mach-o as needed TEMP no -L no script
|
@GrahamcOfBorg build haskell.compiler.ghc6102Binary haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
Package ‘ghc-6.10.2-binary’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/compilers/ghc/6.10.2-binary.nix:97 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-6.10.2-binary’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/ghc/6.10.2-binary.nix:97 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Success for system: x86_64-linux
/nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/ghc-split: interpreter directive changed from "/usr/bin/perl" to "/nix/store/lv85v0qbsm5xk848k6jazb85hhxjlnk1-perl-5.24.3/bin/perl"
checking for references to /tmp/nix-build-ghc-8.2.1-binary.drv-0 in /nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary...
running install tests
[1 of 1] Compiling Main ( main.hs, main.o )
Linking main ...
compilation ok
/nix/store/z0fn6kinmm6k747h94jgz221pwcla0w0-ghc-6.10.2-binary
/nix/store/hvkaw2q9apgdbnjbqv330v4lksv8frsm-ghc-7.10.3-binary
/nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary
/nix/store/5dy9j7278h56ayx4xbx9dnimyp2a9yhd-ghc-7.8.4-binary
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-7.10.3-binary’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/compilers/ghc/7.10.3-binary.nix:19 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
configuring
configure flags: --prefix=/nix/store/qahjdkld6nfkw2zg48ali5fwrqqgmhix-ghc-7.8.4-binary --with-gmp-libraries=/nix/store/7r5mrc8m2kfm2dl1ryv1l5pjqlsqprm7-gmp-6.1.2/lib --with-gmp-includes=/nix/store/az6h3pli4452vfhqvd5chbgn1sf67vkc-gmp-6.1.2-dev/include --with-gcc=/nix/store/5risb4vz1y9agqc2z37f87jpcmvvc26n-gcc-clang-wrapper.sh
checking for path to top of build tree... dyld: Library not loaded: /usr/lib/libiconv.2.dylib
Referenced from: /private/tmp/nix-build-ghc-7.8.4-binary.drv-0/ghc-7.8.4/utils/ghc-pwd/dist-install/build/tmp/ghc-pwd
Reason: no suitable image found. Did find:
/usr/lib/libiconv.2.dylib: file system sandbox blocked stat()
/usr/lib/libiconv.2.dylib: file system sandbox blocked stat()
configure: error: cannot determine current directory
builder for '/nix/store/0s5ccr3hfqpq63b6j3pdq8k1h6cyi8n9-ghc-7.8.4-binary.drv' failed with exit code 1
error: build of '/nix/store/0s5ccr3hfqpq63b6j3pdq8k1h6cyi8n9-ghc-7.8.4-binary.drv', '/nix/store/dawpwwqh6m3gz3cgyj3dshd6km4fc2ys-ghc-8.2.1-binary.drv', '/nix/store/ds3snrhfnnwc4w9bz99s9wdsncl9j3s6-ghc-7.10.3-binary.drv' failed
There was a problem hiding this comment.
Success for system: x86_64-linux
Loading package array-0.5.0.0 ... linking ... done.
Loading package deepseq-1.3.0.2 ... linking ... done.
Loading package containers-0.5.5.1 ... linking ... done.
Loading package pretty-1.1.1.1 ... linking ... done.
Loading package template-haskell ... linking ... done.
Linking main ...
compilation ok
/nix/store/hvkaw2q9apgdbnjbqv330v4lksv8frsm-ghc-7.10.3-binary
/nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary
/nix/store/5dy9j7278h56ayx4xbx9dnimyp2a9yhd-ghc-7.8.4-binary
domenkozar
force-pushed
the
ghc-prebuilt
branch
from
74c9f13
to
e4c05ae
Compare
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-7.10.3-binary’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/compilers/ghc/7.10.3-binary.nix:21 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
error: while evaluating 'callPackageWith' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/haskell-packages.nix:44:20:
while evaluating 'makeOverridable' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
undefined variable 'gcc' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/compilers/ghc/8.2.1-binary.nix:61:141
30f3038
to
1676890
Compare
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
|
Huh, it works for me locally: |
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-7.10.3-binary’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/compilers/ghc/7.10.3-binary.nix:21 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
/nix/store/z3k8y3x9hdz1m2a3c002z21qi7hlly5v-ghc-7.10.3-binary/lib/ghc-7.10.3/ghc_0AG9TOjDEtx4Ji3wSwHOBe
"/nix/store/z3k8y3x9hdz1m2a3c002z21qi7hlly5v-ghc-7.10.3-binary/lib/ghc-7.10.3/bin/ghc-pkg" --force --global-package-db "/nix/store/z3k8y3x9hdz1m2a3c002z21qi7hlly5v-ghc-7.10.3-binary/lib/ghc-7.10.3/package.conf.d" update rts/dist/package.conf.install
dyld: Library not loaded: @executable_path/libiconv.dylib
Referenced from: /nix/store/z3k8y3x9hdz1m2a3c002z21qi7hlly5v-ghc-7.10.3-binary/lib/ghc-7.10.3/bin/ghc-pkg
Reason: no suitable image found. Did find:
/usr/lib/libiconv.dylib: file system sandbox blocked stat()
make[1]: *** [ghc.mk:925: install_packages] Abort trap: 6
make: *** [Makefile:24: install] Error 2
builder for '/nix/store/w3bhvacl5yc4srhids8z4ipji6rdnz52-ghc-7.10.3-binary.drv' failed with exit code 2
error: build of '/nix/store/3bq3qykc8m5h4z3qyd1w5q4akappqal8-ghc-7.8.4-binary.drv', '/nix/store/3s5s5bapwic00qjm9z373bvv42b9rgwz-ghc-8.2.1-binary.drv', '/nix/store/w3bhvacl5yc4srhids8z4ipji6rdnz52-ghc-7.10.3-binary.drv' failed
There was a problem hiding this comment.
Success for system: x86_64-linux
/nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary/share/doc/ghc-8.2.1/html/libraries/gen_contents_index: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
/nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/ghc-split: interpreter directive changed from "/usr/bin/perl" to "/nix/store/lv85v0qbsm5xk848k6jazb85hhxjlnk1-perl-5.24.3/bin/perl"
checking for references to /tmp/nix-build-ghc-8.2.1-binary.drv-0 in /nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary...
running install tests
[1 of 1] Compiling Main ( main.hs, main.o )
Linking main ...
compilation ok
/nix/store/hvkaw2q9apgdbnjbqv330v4lksv8frsm-ghc-7.10.3-binary
/nix/store/41wf0hpwbga1x9flr8fyandz1b523yay-ghc-8.2.1-binary
/nix/store/5dy9j7278h56ayx4xbx9dnimyp2a9yhd-ghc-7.8.4-binary
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-7.10.3-binary’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/compilers/ghc/7.10.3-binary.nix:21 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
ranlib: file: /nix/store/5irffzrfc513a6hlkcffnpafpszi8bhr-ghc-7.8.4-binary/lib/ghc-7.8.4/rts-1.0/libCffi_thr_p.a(ffi.o) has no symbols
ranlib: file: /nix/store/5irffzrfc513a6hlkcffnpafpszi8bhr-ghc-7.8.4-binary/lib/ghc-7.8.4/rts-1.0/libCffi_thr_p.a(darwin.o) has no symbols
"utils/ghc-cabal/dist-install/build/tmp/ghc-cabal-bindist" copy libraries/ghc-prim dist-install "strip" '' '/nix/store/5irffzrfc513a6hlkcffnpafpszi8bhr-ghc-7.8.4-binary' '/nix/store/5irffzrfc513a6hlkcffnpafpszi8bhr-ghc-7.8.4-binary/lib/ghc-7.8.4' '/nix/store/5irffzrfc513a6hlkcffnpafpszi8bhr-ghc-7.8.4-binary/share/doc/ghc/html/libraries' 'v p dyn'
Installing library in
/nix/store/5irffzrfc513a6hlkcffnpafpszi8bhr-ghc-7.8.4-binary/lib/ghc-7.8.4/ghc-prim-0.3.1.0
ghc-cabal: /usr/bin/ranlib: permission denied
make[1]: *** [ghc.mk:907: install_packages] Error 1
make: *** [Makefile:24: install] Error 2
builder for '/nix/store/3bq3qykc8m5h4z3qyd1w5q4akappqal8-ghc-7.8.4-binary.drv' failed with exit code 2
error: build of '/nix/store/3bq3qykc8m5h4z3qyd1w5q4akappqal8-ghc-7.8.4-binary.drv', '/nix/store/3s5s5bapwic00qjm9z373bvv42b9rgwz-ghc-8.2.1-binary.drv' failed
|
I consider this ready, it builds on my darwin machine. Once this is merged I can replace the boot packages and ghc for sets and thus get rid of long current ghc cycles. |
domenkozar
force-pushed
the
ghc-prebuilt
branch
from
1676890
to
bd7c8ea
Compare
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-7.10.3-binary’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/ghc/7.10.3-binary.nix:21 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
/nix/store/gwib0z9njhrqwb3v9fk8vic2z2xywnvz-ghc-7.8.4-binary/lib/ghc-7.8.4/haskell2010-1.1.2.0
"/nix/store/gwib0z9njhrqwb3v9fk8vic2z2xywnvz-ghc-7.8.4-binary/lib/ghc-7.8.4/bin/ghc-pkg" --force --global-package-db "/nix/store/gwib0z9njhrqwb3v9fk8vic2z2xywnvz-ghc-7.8.4-binary/lib/ghc-7.8.4/package.conf.d" update rts/dist/package.conf.install
dyld: Library not loaded: @executable_path/libiconv.dylib
Referenced from: /nix/store/gwib0z9njhrqwb3v9fk8vic2z2xywnvz-ghc-7.8.4-binary/lib/ghc-7.8.4/bin/ghc-pkg
Reason: no suitable image found. Did find:
/usr/lib/libiconv.dylib: file system sandbox blocked stat()
make[1]: *** [ghc.mk:908: install_packages] Abort trap: 6
make: *** [Makefile:24: install] Error 2
builder for '/nix/store/2jrd83idfq2ydkfkcpgdi5785d1czr4d-ghc-7.8.4-binary.drv' failed with exit code 2
error: build of '/nix/store/2jrd83idfq2ydkfkcpgdi5785d1czr4d-ghc-7.8.4-binary.drv', '/nix/store/3s5s5bapwic00qjm9z373bvv42b9rgwz-ghc-8.2.1-binary.drv' failed
|
@GrahamcOfBorg build haskell.compiler.ghc7103Binary haskell.compiler.ghc821Binary haskell.compiler.ghc784Binary |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘ghc-7.10.3-binary’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/compilers/ghc/7.10.3-binary.nix:21 is not supported on ‘aarch64-linux’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
|
Yayayayay thanks for finishing! This should be staging, or @peti's staging branch though? |
|
Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. |
7 tasks
|
@peti seems to not break anything. I have a follow-up PR that wires up boot packages (and thus removes long ghc chain). But currently ghcjs fails on master: https://hydra.nixos.org/job/nixpkgs/trunk/haskell.compiler.ghcjs.x86_64-linux I think we should add |
|
@peti also let me know if you'd like to include changing of bootstrapped ghc in this PR or as a separate thing. I have changes ready. There are no regressions, but some older and very new GHCs fail to build, prior to the change. |
|
@domenkozar, I'd prefer to merge the additional changes in a separate PR. Let's make small, continuous steps. If something goes wrong, a sequence of small incremental is easier to bisect and to find the cause of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #29688 and addresses the blocker to build ghcs on linux.