color_coded: init at 2017-10-30 #33060

jeaye · 2017-12-26T00:10:31Z

Motivation for this change

It's a popular vim plugin which I'd like to have on my NixOS machines.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

This is a bit messier than it would be with mkDerivation, but I've found that buildVimPluginFrom2Nix doesn't seem to have very good CMake support.

LnL7 · 2017-12-29T22:53:36Z

pkgs/misc/vim-plugins/default.nix

+      sha256 = "0l46ar1b3vy7gbrq2ic734vvw7zcvw6ar78zyhwz55h2lxfh89aq";
+    };
+    dependencies = [];
+    buildInputs = [


This file is generated, the custom part belongs in additional-nix-code/color_coded.

I tried that initially and found that my additional-nix-code/color_coded wasn't being used at all; didn't find any further documentation and I see other plugins in default.nix are specifying their build inputs, so I went ahead with it.

It's used when updating all of the plugins, vim-plugin-names-to-nix generates the part until dependencies = []; and appends the custom snippet afterwards.

Yeah, I see the benefit of separating the build bits, since they likely don't change with the auto-generated bits. It's the way that it is because additional-nix-code/color_coded didn't work for me and I didn't find any more docs or support elsewhere. If you have any more info, I can try to apply that. If it should just work then maybe I need to try it again.

LnL7 · 2017-12-29T22:56:08Z

pkgs/misc/vim-plugins/default.nix

+      clang_version=$(clang --version | head -1 | sed 's/clang version \(\S\+\).*/\1/')
+      . ./lib/generate_sources ${llvm_39} $clang_version
+
+      cmake -DDOWNLOAD_CLANG=0 .


I remember you asking about this in irc, could you link the mkDerivation that did work.

with import <nixpkgs> {}; stdenv.mkDerivation { name = "color_coded-2017-10-30"; src = fetchgit { url = "https://github.com/jeaye/color_coded"; rev = "cb356b083362ea6f15bc690c5eb10b01326ad169"; sha256 = "0l46ar1b3vy7gbrq2ic734vvw7zcvw6ar78zyhwz55h2lxfh89aq"; }; dependencies = []; buildInputs = [ stdenv cmake lua ncurses zlib llvm llvmPackages.clang.cc ]; cmakeFlags = [ "-DDOWNLOAD_CLANG=0" ]; preConfigure = '' sed -i "s/add_dependencies(\S\+ \S\+_track_api)//" CMakeLists.txt clang_version=$(clang --version | head -1 | sed 's/clang version $\S\+$.*/\1/') . ./lib/generate_sources ${llvm} $clang_version ''; buildPhase = '' patchShebangs . make install ''; }

This fixes the issues with cmake #33203

Excellent. Thank you!

LnL7 · 2017-12-29T22:56:35Z

@GrahamcOfBorg build vimPlugins.color_coded

GrahamcOfBorg

Failure for system: x86_64-darwin

  /nix/store/j3yfhwcz55i0yb8g5bnp40py9dzy9rf5-cmake-3.9.6/share/cmake-3.9/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/j3yfhwcz55i0yb8g5bnp40py9dzy9rf5-cmake-3.9.6/share/cmake-3.9/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:50 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-vimplugin-color_coded-2017-10-30.drv-0/color_coded-cb356b0/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-vimplugin-color_coded-2017-10-30.drv-0/color_coded-cb356b0/CMakeFiles/CMakeError.log".
builder for ‘/nix/store/mkkabx30riyr1xhbiz1irg132q9bfbq6-vimplugin-color_coded-2017-10-30.drv’ failed with exit code 1
error: build of ‘/nix/store/mkkabx30riyr1xhbiz1irg132q9bfbq6-vimplugin-color_coded-2017-10-30.drv’ failed

GrahamcOfBorg

Success for system: x86_64-linux

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/xzvkzh9ryvkrj1mambqg8fyp02pzvzr8-vimplugin-color_coded-2017-10-30

GrahamcOfBorg

Success for system: aarch64-linux

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/pz1dfgzi6z5a4354qnkvgsfiivjpz86d-vimplugin-color_coded-2017-10-30

LnL7 · 2017-12-29T23:06:04Z

pkgs/misc/vim-plugins/default.nix

+      ncurses
+      zlib
+      llvm_39
+      llvmPackages.clang.cc


I think this might be causing the darwin failure, since the stdenv there already uses clang.

jeaye · 2017-12-30T21:46:23Z

@GrahamcOfBorg build vimPlugins.color_coded

LnL7 · 2017-12-30T21:54:51Z

@GrahamcOfBorg build vimPlugins.color_coded

GrahamcOfBorg

Success for system: x86_64-darwin

[ 84%] Linking CXX executable color_coded_config_test
[ 84%] Built target color_coded_config_test
Scanning dependencies of target color_coded
[ 92%] Building CXX object CMakeFiles/color_coded.dir/src/main.cpp.o
[100%] Linking CXX shared library color_coded.so
[100%] Built target color_coded
installing
post-installation fixup
patching script interpreter paths in /nix/store/zrsnci01sln8f8zbiqacwwkfz107xxc4-vimplugin-color_coded-2017-10-30
/nix/store/zrsnci01sln8f8zbiqacwwkfz107xxc4-vimplugin-color_coded-2017-10-30

GrahamcOfBorg

Success for system: x86_64-linux

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/dy7ip4i5jbvxivya3mippzywdkah3bhz-vimplugin-color_coded-2017-10-30

GrahamcOfBorg

Success for system: aarch64-linux

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/gfndqcxlm6w907zx15zz3jlm5rd2kani-vimplugin-color_coded-2017-10-30

jeaye · 2017-12-31T00:10:47Z

I've simplified this as much as possible and it builds on all platforms. Let me know if anything else is neeed.

LnL7

Looks good now, could you squash the commits?

LnL7 · 2018-01-02T20:03:50Z

pkgs/misc/vim-plugins/default.nix

+    };
+    dependencies = [];
+    buildInputs = [
+      stdenv


you don't need to add stdenv here, also nativeBuildInputs is more correct for cmake.

I'll remove stdenv, move cmake to nativeBuildInputs, and squash the commits tonight.

Did this ever happen?

jeaye · 2018-06-10T22:26:11Z

@7c6f434c @LnL7 Squashed, removed stdenv, and moved cmake to nativeBuildInputs, as requested. Thanks for the ping.

LnL7 · 2018-06-11T20:09:40Z

pkgs/misc/vim-plugins/default.nix

@@ -4,6 +4,7 @@
 , xkb_switch, rustracerd, fzf, skim
 , python3, boost, icu, ncurses
 , ycmd, makeWrapper, rake
+, lua51Packages, ncurses, zlib, llvm_39


Looks like meanwhile ncurses was already added to the inputs for something else.

jeaye · 2018-06-11T20:13:25Z

@LnL7 Good catch. Removed the extra ncurses.

LnL7 · 2018-06-11T21:15:09Z

@GrahamcOfBorg build vimPlugins.color_coded

GrahamcOfBorg · 2018-06-11T21:16:15Z

Failure on x86_64-darwin (full log)

Attempted: vimPlugins.color_coded

Partial log (click to expand)

      color_coded::clang::source_range(color_coded::clang::translation_unit const&) in main.cpp.o
  "_clang_parseTranslationUnit", referenced from:
      color_coded::clang::compile(color_coded::conf::args_view, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in main.cpp.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/color_coded_config_test.dir/build.make:128: color_coded_config_test] Error 1
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/color_coded_config_test.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/lfc2vbh1l9qhcnfm57a60cy10jiagxxy-vimplugin-color_coded-2017-10-30.drv' failed with exit code 2
error: build of '/nix/store/lfc2vbh1l9qhcnfm57a60cy10jiagxxy-vimplugin-color_coded-2017-10-30.drv' failed

GrahamcOfBorg · 2018-06-11T21:17:10Z

Failure on x86_64-linux (full log)

Attempted: vimPlugins.color_coded

Partial log (click to expand)

CMakeFiles/color_coded_config_test.dir/test/src/config/main.cpp.o: In function `color_coded::clang::detail::resource_impl<CXString>::deleter(CXString&)':
main.cpp:(.text._ZN11color_coded5clang6detail13resource_implI8CXStringE7deleterERS3_[_ZN11color_coded5clang6detail13resource_implI8CXStringE7deleterERS3_]+0xb): undefined reference to `clang_disposeString'
CMakeFiles/color_coded_config_test.dir/test/src/config/main.cpp.o: In function `color_coded::clang::translation_unit::~translation_unit()':
main.cpp:(.text._ZN11color_coded5clang16translation_unitD2Ev[_ZN11color_coded5clang16translation_unitD5Ev]+0xd): undefined reference to `clang_disposeTranslationUnit'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/color_coded_config_test.dir/build.make:128: color_coded_config_test] Error 1
make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/color_coded_config_test.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/xdk6hlmzzc89abhqhca3p5qr1f9yq91a-vimplugin-color_coded-2017-10-30.drv' failed with exit code 2
error: build of '/nix/store/xdk6hlmzzc89abhqhca3p5qr1f9yq91a-vimplugin-color_coded-2017-10-30.drv' failed

GrahamcOfBorg · 2018-06-11T21:17:42Z

Failure on aarch64-linux (full log)

Attempted: vimPlugins.color_coded

Partial log (click to expand)

CMakeFiles/color_coded_config_test.dir/test/src/config/main.cpp.o: In function `color_coded::clang::detail::resource_impl<CXString>::deleter(CXString&)':
main.cpp:(.text._ZN11color_coded5clang6detail13resource_implI8CXStringE7deleterERS3_[_ZN11color_coded5clang6detail13resource_implI8CXStringE7deleterERS3_]+0x4): undefined reference to `clang_disposeString'
CMakeFiles/color_coded_config_test.dir/test/src/config/main.cpp.o: In function `color_coded::clang::translation_unit::~translation_unit()':
main.cpp:(.text._ZN11color_coded5clang16translation_unitD2Ev[_ZN11color_coded5clang16translation_unitD5Ev]+0x14): undefined reference to `clang_disposeTranslationUnit'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/color_coded_config_test.dir/build.make:128: color_coded_config_test] Error 1
make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/color_coded_config_test.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/gnmb0n86m03wpd3v23ispid8cszg4ccf-vimplugin-color_coded-2017-10-30.drv' failed with exit code 2
error: build of '/nix/store/gnmb0n86m03wpd3v23ispid8cszg4ccf-vimplugin-color_coded-2017-10-30.drv' failed

LnL7 · 2018-06-15T20:52:11Z

Any ideas about the build failures? It worked at some point.

jeaye · 2018-06-16T17:41:03Z

The source hasn't changed and I'm specifically using llvm_39. This appears to be a fagility between the relationship of llvm_39 and llvmPackages, used here: https://github.com/NixOS/nixpkgs/pull/33060/files#diff-eab8cee5bbb648c553d5b5aba8ec6a10R12

Is there a better way to get access to the clang libs?

mmahut · 2019-08-07T21:14:30Z

Any updates on this pull request, please?

stale · 2020-06-01T17:08:37Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

stale · 2021-06-06T19:57:28Z

I marked this as stale due to inactivity. → More info

Mindavi · 2021-10-13T18:16:38Z

If you're still interested in pushing this into nixpkgs, I'd suggest you re-submit. Since there hasn't been any activity for so long, I feel like it's best to close it. Please feel free to reopen if you'd like.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 26, 2017

LnL7 added the 6.topic: vim label Dec 29, 2017

LnL7 suggested changes Dec 29, 2017

View reviewed changes

GrahamcOfBorg reviewed Dec 29, 2017

View reviewed changes

LnL7 reviewed Dec 29, 2017

View reviewed changes

GrahamcOfBorg reviewed Dec 30, 2017

View reviewed changes

LnL7 approved these changes Jan 2, 2018

View reviewed changes

LnL7 suggested changes Jun 11, 2018

View reviewed changes

color_coded: init at 2017-10-30

2819db4

GrahamcOfBorg added the 8.has: package (new) label Jun 11, 2018

joachifm added the 2.status: merge conflict label Aug 19, 2018

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021

Mindavi closed this Oct 13, 2021

color_coded: init at 2017-10-30 #33060

color_coded: init at 2017-10-30 #33060

Conversation

jeaye commented Dec 26, 2017

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 Dec 29, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 commented Dec 29, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeaye commented Dec 30, 2017

LnL7 commented Dec 30, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

jeaye commented Dec 31, 2017

LnL7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeaye commented Jun 10, 2018

Choose a reason for hiding this comment

jeaye commented Jun 11, 2018

LnL7 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

LnL7 commented Jun 15, 2018

jeaye commented Jun 16, 2018

mmahut commented Aug 7, 2019

stale bot commented Jun 1, 2020

stale bot commented Jun 6, 2021

Mindavi commented Oct 13, 2021

LnL7 Dec 29, 2017 •

edited