way-cooler: 0.6.2 -> 0.7.0 #33044
Closed
way-cooler: 0.6.2 -> 0.7.0 #33044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @miltador |
grahamc
reviewed
Dec 26, 2017
| way-cooler = ((callPackage ./way-cooler.nix {}).way_cooler_0_6_2.override { | ||
| lua = lua5_3.overrideAttrs (oldAttrs: rec { | ||
| postFixup = '' | ||
| ln -s $out/lib/liblua.so $out/lib/liblua5.3.so |
There was a problem hiding this comment.
This seems weird. Why not just patch lua to do this itself always?
GrahamcOfBorg
added
10.rebuild-linux: 101-500
and removed
10.rebuild-linux: 1-10
labels
ghost
reviewed
Dec 27, 2017
| dbus = attrs: { buildInputs = [ pkgconfig dbus_libs ]; }; | ||
| gobject-sys = attrs: { buildInputs = [ dbus_glib ]; }; | ||
| gio-sys = attrs: { buildInputs = [ dbus_glib ]; }; | ||
| gdk-pixbuf-sys = attrs: { buildInputs = [ dbus_glib ]; }; | ||
| gdk-pixbuf = attrs: { buildInputs = [ dbus_glib gdk_pixbuf ]; }; |
There was a problem hiding this comment.
Is it a good idea to specify this in default-crate-overrides.nix instead?
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)