(haskell.packages.ghc802.ghc): (fix llvm dependency) #33045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect LLVM dependency of GHC 8.0.x to be 3.7 instead of 3.5.
|
@jflanglois is there a reason GHC 8 depends on such an old version of LLVM? It's now the only package in nixpkgs that depends on 3.7 and thus the only thing keeping it around. I ask because of #30229, because it's quite burdensome to keep maintaining these LLVM packages, especially when they take a billion years to compile each. Can GHC8 be bumped to a newer version of LLVM somehow? |
|
@copumpkin I believe that the versions are pretty strongly tied because of how llvm is used (I'm not very knowledgeable about the internals). We could test it out with a more recent version, but perhaps it would be better to just disable llvm for ghc 8.0 altogether? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The LLVM version associated with GHC 8.0.x is wrong.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)See Installing & Using the LLVM Back-end
Tested against a simple invocation of
ghc --make -fllvm Main.hs.