Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vala: patch releases for 0.23, 0.28, 0.34, 0.36 and 0.38 #32795

Merged
merged 1 commit into from Dec 29, 2017
Merged

vala: patch releases for 0.23, 0.28, 0.34, 0.36 and 0.38 #32795

merged 1 commit into from Dec 29, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

A bunch of patch releases have been made as updates to the various versions we package.

It causes a non-insignificant amount of rebuilding...

They build here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 18, 2017

Are all versions of vala we have in nixpkgs actively maintained upstream?

@Mic92
Copy link
Member

Mic92 commented Dec 18, 2017 •
edited

So according to the website: https://wiki.gnome.org/Projects/Vala/
the following stable versions are maintained: 0.34.13, 0.36.8, 0.38.4
and 0.39.2 is marked as unstable.

I have created a separate issue here to remove old versions: #32800
so you can go ahead with merging this one.

@Mic92 Mic92 mentioned this pull request Dec 18, 2017
Closed
@jtojnar
Copy link
Contributor

jtojnar commented Dec 18, 2017

Why are you re-adding 0.36 when that one is not used anywhere?

@jtojnar jtojnar added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (update) labels Dec 18, 2017
@Mic92
Copy link
Member

Mic92 commented Dec 18, 2017

Yes, I would only add 0.36.8 as necessary.

@Mic92
Copy link
Member

Mic92 commented Dec 18, 2017

@peterhoeg Can you retarget the pull request to the staging branch? I don't expect many breakages with minor upgrades and that way we can avoid large rebuilds blocking the unstable channel.

@peterhoeg
Copy link
Member Author

Why are you re-adding 0.36 when that one is not used anywhere?

It's a version maintained by upstream, the marginal cost of adding it in is negligible and it lowers the barriers of entry for whoever might need it.

I can fully understand if "there are no users, so it doesn't belong here" overrules it, but from my point of view, I think it makes sense to apply the "whatever makes it easier for people to use nixos/nixpkgs".

@vcunat vcunat changed the base branch from master to staging December 26, 2017 15:08
@vcunat vcunat merged commit 38d8bcd into NixOS:staging Dec 29, 2017
vcunat added a commit that referenced this pull request Dec 29, 2017
@vcunat
Merge #32795: vala_*: patch updates
1963be9
@peterhoeg peterhoeg deleted the u/vala branch December 30, 2017 00:48
@peterhoeg peterhoeg restored the u/vala branch December 30, 2017 01:25
@peterhoeg peterhoeg deleted the u/vala branch March 5, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @Mic92 @jtojnar @vcunat @GrahamcOfBorg