Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elementary-gtk-theme: init at 5.1.1 #32785

Merged
merged 1 commit into from Dec 24, 2017
Merged

elementary-gtk-theme: init at 5.1.1 #32785

merged 1 commit into from Dec 24, 2017

Conversation

davidak
Copy link
Member

@davidak davidak commented Dec 18, 2017 •
edited

Motivation for this change

The master plan is to have a full Pantheon desktop.

Here is it with Xfce, greybird window decorator and elementary-xfce-icon-theme.

screenshot_2017-12-18_01-24-59

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

You might want to check Xfce 4.13 (#32763) for updated GTK+ 3 looks.

@davidak
Copy link
Member Author

davidak commented Dec 18, 2017

@yegortimoshenko i have seen the PR. Will check it out when merged.

lukateras
lukateras approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot_2017-12-18_00-37-38

screenshot_2017-12-18_00-39-46

pkgs/misc/themes/elementary/default.nix Outdated
src = fetchFromGitHub {
owner = "elementary";
repo = "stylesheet";
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: could also be just rev = version;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed. thanks

@orivej orivej merged commit d7e6066 into NixOS:master Dec 24, 2017
@davidak davidak deleted the elementary-gtk-theme branch March 27, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidak @lukateras @orivej @GrahamcOfBorg