Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: 1.8.1 -> 1.7.9 #32768

Merged
merged 1 commit into from Dec 18, 2017
Merged

electron: 1.8.1 -> 1.7.9 #32768

merged 1 commit into from Dec 18, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 17, 2017 •
edited

Motivation for this change

Downgrade Electron to latest stable version. See #32398, #32741, #32765.

I can't reproduce that bug in Rambox with Electron 1.7.9. /cc @gnidorah

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ghost
ghost reviewed Dec 17, 2017
View reviewed changes
pkgs/development/tools/electron/default.nix Outdated
@@ -18,23 +18,15 @@ let
src = {
i686-linux = fetchurl {
url = "https://github.com/electron/electron/releases/download/v${version}/electron-v${version}-linux-ia32.zip";
sha256 = "0djqlcs4m9n9354idaqcs4cwskq2m3sf9mzvxpp4wy0a93pk78bw";
name = "${name}.zip";
sha256 = "0m87n7hqimg93z3m8pa1ggs69f3h5mjrsrrl7x80hxmp3w142krc";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation nits :-)

@lukateras
Copy link
Member Author

lukateras commented Dec 17, 2017 •
edited

electron is currently used only in 2 derivations (rambox, nix-tour). Maintaining one Electron branch is troublesome enough, given it's a binary derivation with 4-5 target platforms. And their beta branch apparently can contain critical bugs.

Those facts combined make me think that it's more trouble than it's worth.

@lukateras
Copy link
Member Author

BTW, I have a source-based Electron in the works, but it will take a while because their build system implies internet access, which makes it hard to get working, all dependencies are pinned/vendored, and builds take a very long time.

@lukateras
Copy link
Member Author

lukateras commented Dec 17, 2017 •
edited

This pull request follows the upstream. v1.7.9 is the latest stable version, v1.8.1 is beta. I don't believe that pre-release versions should be packaged by default.

Rambox is just an HTML page and some JavaScript. It's a highly sandboxed environment, and if anything breaks to the point of a failed assert in such environment, release is probably buggy.

@ghost ghost mentioned this pull request Dec 18, 2017
Closed
8 tasks
@ghost
Copy link

ghost commented Dec 18, 2017

@yegortimoshenko

I can't reproduce that bug in Rambox with Electron 1.7.9

Same for me. Thank you!

@lukateras @orivej
electron: 1.8.1 -> 1.7.9
a9d212f 
1.7.9 is the latest stable, and 1.8.1 is beta and it draws `rambox` as a white
rectangle (after a few manipulations with the window such as hiding, showing,
resizing): NixOS#32741 (comment)
@orivej orivej merged commit 8f53673 into NixOS:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @grahamc @Mic92 @orivej