mnemosyne: 2.3.2 -> 2.6 #32799
Merged
mnemosyne: 2.3.2 -> 2.6 #32799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
force-pushed
the
mnemosyne
branch
2 times, most recently
from
d4c089d
to
3601331
Compare
|
@GrahamcOfBorg eval |
|
Is anybody able to run Mnemosyne from the unstable channel? |
|
The alternative would be to mark mnemosyne as broken and wait until someone who really needs it comes by. Does this fit you better @FRidh? |
|
Often specifying helps with errors like these. |
|
However, if you say the error also occurs during runtime... You can indeed mark it has broken. Let someone who wants this step up and fix it. |
|
I think I didn't express myself very well :) The current status in master is: Mnemosyne builds fine but doesn't run, at least for me: Regarding this PR: Mnemosyne does build AND run. I however wasn't able to make the tests run. I had another look at the tests and I think we won't be able to enable them:
My proposal would be merge this one, since it IS in a working state and I don't see any problem with the disabled tests. @GrahamcOfBorg build mnemosyne |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
ping @FRidh |
FRidh
reviewed
Feb 11, 2018
pkgs/games/mnemosyne/default.nix
Outdated
| src = fetchurl { | ||
| url = "http://sourceforge.net/projects/mnemosyne-proj/files/mnemosyne/${name}/Mnemosyne-${version}.tar.gz"; | ||
| sha256 = "0jkrw45i4v24p6xyq94z7rz5948h7f5dspgs5mcdaslnlp2accfp"; | ||
| url = "http://sourceforge.net/projects/mnemosyne-proj/files/mnemosyne/${pname}-${version}/Mnemosyne-${version}.tar.gz"; |
There was a problem hiding this comment.
can you use mirror://sourceforge?
pkgs/top-level/all-packages.nix
Outdated
| @@ -18489,7 +18489,9 @@ with pkgs; | |||
| libpng = libpng12; | |||
| }; | |||
|
|
|||
| mnemosyne = callPackage ../games/mnemosyne { }; | |||
| mnemosyne = libsForQt5.callPackage ../games/mnemosyne { | |||
| inherit (python3Packages) buildPythonApplication pyqt5 matplotlib cherrypy cheroot webob pillow; | |||
There was a problem hiding this comment.
Please don't make these kind of changes. They can only cause more work when there are incompatible versions.
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
FRidh
reviewed
Feb 11, 2018
pkgs/games/mnemosyne/default.nix
Outdated
| postInstall = '' | ||
| mkdir -p $out/share | ||
| mv $out/lib/python2.7/site-packages/$out/share/locale $out/share | ||
| rm -r $out/lib/python2.7/site-packages/nix | ||
| mv $out/lib/python*/site-packages/$out/share/locale $out/share |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mnemosyne was broken previously, because tests failed during install.
I updated it, but still something goes very wrong in the checkPhase if I don't disable checks:
At least, I'm now able to run the program.
Nevertheless, there also seem to be errors within the program. For example, when starting a server and accessing it via web browser (http://localhost:8513/), some error with a
NoneTypeoccurs.I sadly don't have the time to look into these and I've also never made contact with PyQt.
/cc @lverns @domenkozar @peti
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)