Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm-spank-x11: init at 0.2.5 #32774

Merged
merged 1 commit into from Feb 10, 2018
Merged

slurm-spank-x11: init at 0.2.5 #32774

merged 1 commit into from Feb 10, 2018

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Dec 17, 2017 •
edited

Motivation for this change

srun allows to run interactive session on compute nodes. The slurm-spank-x11 plugin adds the
possibility to also forward X11, which is not possible in the standard setup. This addon
is the recommended method of integrating X11 from the slurm website (https://slurm.schedmd.com/faq.html#x11). This commit adds the plugin as a new package
and integrates it into NixOS via a new option (enableSrunX11) in the slurm module.

CC @jagajaga

Things done

Tested in a virtualbox setup with minimal configuration.nix.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    slurm test still succeeds.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Feb 10, 2018

@GrahamcOfBorg build slurm-spank-x11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5
shrinking /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5/bin/slurm-spank-x11
shrinking /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5/lib/x11.so
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5/lib  /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5/bin
patching script interpreter paths in /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5
checking for references to /build in /nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5...
/nix/store/b0sdchif6xp0dqmnqrrazbzmi04lfj71-slurm-spank-x11-0.2.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5
shrinking /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5/lib/x11.so
shrinking /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5/bin/slurm-spank-x11
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5/lib  /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5/bin
patching script interpreter paths in /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5
checking for references to /build in /nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5...
/nix/store/l6z9faaimrbkrwf104swqlspf7r3cc2n-slurm-spank-x11-0.2.5

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘slurm-spank-x11-0.2.5’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/servers/computing/slurm-spank-x11/default.nix:31 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@vcunat vcunat merged commit 85ca8f1 into NixOS:master Feb 10, 2018
vcunat added a commit that referenced this pull request Feb 10, 2018
@vcunat
Merge #32774: slurm-spank-x11: init at 0.2.5
968b866
@markuskowa markuskowa deleted the slurm-x11 branch February 12, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @vcunat @GrahamcOfBorg