pythonPackages.pwntools: disable tests #32770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Dec 17, 2017
| @@ -17,6 +17,7 @@ buildPythonPackage rec { | |||
| propagatedBuildInputs = [ Mako packaging pysocks pygments ROPGadget capstone paramiko pip psutil pyelftools pypandoc pyserial dateutil requests tox pandoc unicorn intervaltree ]; | |||
|
|
|||
| disabled = isPy3k; | |||
| doCheck = false; | |||
There was a problem hiding this comment.
Could you just add a comment here stating the archive doesn't include tests.
There aren't any tests to run, and now the package fails to build because of a crash while looking if there are any tests.
kristoff3r
force-pushed
the
fix/pwntools
branch
from
26050cb
to
56949d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There aren't any tests to run, and now the package fails to build
because of a crash while looking if there are any tests.
The crash itself seems to happen because TERM isn't set while loading the pwntools terminal handling module, and first started happening at 2017-12-08 according to hydra. I don't know what changed, but it doesn't really matter when the package works and there weren't any tests to begin with.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)