Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce: SVG icon support in xfce4-panel, fixes #18536 #32787

Merged
merged 1 commit into from Dec 18, 2017
Merged

xfce: SVG icon support in xfce4-panel, fixes #18536 #32787

merged 1 commit into from Dec 18, 2017

Conversation

lukateras
Copy link
Member

Motivation for this change

Fixes #18536. /cc @davidak

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
xfce: SVG icon support in xfce4-panel, fixes NixOS#18536
209cbf9 
Thanks to Yuriy Pitomets, Jonathan Curran, and David Kleuker.
@lukateras
Copy link
Member Author

@davidak Have you tried to build it?

@davidak
Copy link
Member

davidak commented Dec 18, 2017

@yegortimoshenko yes, works fine. thank you!

vcunat
vcunat approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine.

@orivej
Copy link
Contributor

orivej commented Dec 18, 2017

What application can be used for testing?

@davidak
Copy link
Member

davidak commented Dec 18, 2017

@orivej you can see this icon theme with Xfce #32745 (comment)
Maybe there is another icon theme with SVG icons already packaged that you can use to test this.

@orivej orivej merged commit a65525b into NixOS:master Dec 18, 2017
@lukateras lukateras added the 6.topic: xfce The Xfce Desktop Environment label Dec 18, 2017
@infinisil infinisil mentioned this pull request Sep 17, 2018
Open
@jagerman jagerman mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukateras @davidak @orivej @vcunat @GrahamcOfBorg