Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trezor GPG Agent #32773

Closed
wants to merge 3 commits into from
Closed

Trezor GPG Agent #32773

wants to merge 3 commits into from

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Dec 17, 2017

Motivation for this change

This adds an option to enable trezor-agent, a GPG agent that enables GPG encrypting and signing with a Trezor hardware wallet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jb55
trezor-agent: 0.9.0 -> 0.9.2
513b08a 
trezor-agent now splits agents into different packages. This commit still points
trezor_agent to the trezor-specific agent to maintain backwards compatibility.

We should probably abstract this a bit into ledgernano_agent, keepkey_agent, etc
@jb55
trezor-agent: support qt pinentry on non-ttys
da6b9b2 
Needed for the system service
@jb55
trezor-agent: system service for trezor-gpg-agent
e04ddd3 
Allows you to use your Trezor as a GnuPG agent
@jb55 jb55 requested a review from FRidh as a code owner December 17, 2017 20:23
FRidh
FRidh requested changes Feb 11, 2018
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -22388,18 +22388,27 @@ EOF
trezor_agent = buildPythonPackage rec{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reviewing this! will do

@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

@fpletz is it ok to add trezor to this module?

fpletz
fpletz approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on putting it in the gnupg module but please move the python module as @FRidh suggested.

@jb55
Copy link
Contributor Author

jb55 commented Apr 13, 2018

libagent keeps breaking, this time due to a few deps. bah! will have to revisit.

@jb55 jb55 closed this Apr 13, 2018
@jb55 jb55 mentioned this pull request Oct 5, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: module (update) 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jb55 @FRidh @fpletz @GrahamcOfBorg