Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyQt to 5.9.2 #32778

Merged
merged 2 commits into from Dec 24, 2017
Merged

Update PyQt to 5.9.2 #32778

merged 2 commits into from Dec 24, 2017

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Dec 17, 2017 •
edited

Motivation for this change

Fixes compatability with Qt 5.9.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Enzime Enzime requested a review from FRidh as a code owner December 17, 2017 21:28
@orivej orivej merged commit 9d70b99 into NixOS:master Dec 24, 2017
@orivej
Copy link
Contributor

orivej commented Dec 24, 2017

Thank you!

@Enzime Enzime deleted the update/pyqt5.9.2 branch December 31, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @orivej @GrahamcOfBorg