rambox: lock electron to 1.7.5 #32765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 17, 2017
| @@ -12,6 +12,17 @@ let | |||
| }; | |||
| sencha = callPackage ./sencha {}; | |||
| }; | |||
| # https://github.com/NixOS/nixpkgs/pull/32741#issuecomment-352203170 | |||
| electron_1_7 = electron.overrideAttrs (oldAttrs: rec { | |||
There was a problem hiding this comment.
maybe also add a command to reevaluate this decision in future versions of rambox.
|
I think downgrading tree-wide is the right way to go. This is an issue only because we use pre-release version of Electron. |
|
Closing in favor of #32768 |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)