Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract files one at a time from all-cabal-hashes #32772

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ElvishJerricco
Copy link
Contributor Author

@shlevy Didn't know if I should update all-cabal-hashes along with this, so I left it at the version it was at in release-17.03.

@grahamc
Copy link
Member

grahamc commented Dec 17, 2017

Hmmm a PR to release-17.03? 17.03 hasn't been supported for 4 months now.

@ElvishJerricco
Copy link
Contributor Author

Just acting on this request: #31333 (comment)

@shlevy
Copy link
Member

shlevy commented Dec 18, 2017

@grahamc Is it a problem to merge things back so long as users know they have to do the work themselves to keep it secure and up-to-date?

@grahamc
Copy link
Member

grahamc commented Dec 18, 2017 via email

@shlevy
Copy link
Member

shlevy commented Dec 18, 2017

@grahamc I told them when I worked there 😉

@ElvishJerricco
Copy link
Contributor Author

Will this be merged?

@orivej
Copy link
Contributor

orivej commented Dec 20, 2017

@mightybyte Do you need this? Could you share a bit on why you'd rather not switch to 17.09?

@shlevy
Copy link
Member

shlevy commented Dec 20, 2017

@ElvishJerricco Is Takt aware that 17.03 is unmaintained and may miss critical security updates if they don't support them themselves? If so then I think we can merge your changes.

@ElvishJerricco
Copy link
Contributor Author

@mightybyte thoughts?

@mightybyte
Copy link
Contributor

Yes, this would be very useful for us. Switching to 17.09 has not proven to be trivial. Also, less than a year of official support for major releases is not great when it comes to supporting mission-critical codebases.

@shlevy shlevy merged commit aea4ac8 into NixOS:release-17.03 Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants