Add guard clause to Deque#rotate! #5399
Merged
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to Crystal, so please let me know if there's something I should change. I went back and forth on writing the guard clause as
@size == 0
orempty?
.shift
andpop
used@size == 0
.halfs
usedempty?
.On one hand, the error this is fixing is due to
@size
being zero. But on the other hand, it makes the most intuitive sense to me that we're short circuiting the rotation when the Deque is empty, because an empty Deque (or Array or whatever) rotated is still an empty Deque.Come to think of it, we can actually return early if
@size <= 1
because a Deque of size 1 rotated any amount is still the same value.Would you like me to change this guard clause to
@size <= 1
, leave it as is, or change it to@size == 0
?Fixes #5393