Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denemo: init at 2.2.0 #33098

Merged
merged 1 commit into from Dec 29, 2017
Merged

denemo: init at 2.2.0 #33098

merged 1 commit into from Dec 29, 2017

Conversation

olynch
Copy link
Contributor

@olynch olynch commented Dec 27, 2017

Motivation for this change

Added denemo, an app for writing music. My editor seems to have also removed two extraneous from all-packages.nix, I could amend the commit if you want, but if it's not a problem I see no reason why not to leave it in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

lukateras
lukateras approved these changes Dec 29, 2017
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and starts.

@lukateras lukateras merged commit 2d4426a into NixOS:master Dec 29, 2017
@lukateras
Copy link
Member

Also, removing trailing whitespace is good! Thanks for the contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olynch @lukateras @GrahamcOfBorg