[WIP] init: create /dev/root in stage 2 too #33067
Conversation
|
Is there any reason to create the symlink in stage 1 ? maybe I could remove it from there so that it isn't done twice (or check if it exists beforehand) ? |
When running nixops-libvirt with a host kernel via the command line
cmdline="root=/dev/sda1 earlycon=ttyS0 console=ttyS0
init=/nix/var/nix/profiles/system/init boot.debug=1 boot.consoleLogLevel=1 ";
kernel="/host/kernel/arch/x86_64/boot/bzImage";
/proc/cmdline can't be read in stage 1 and thus /dev/root doesn't exist
which makes `nixops deploy` fail with
==========
client> copying closure...
server> copying closure...
e> closures copied successfully
client> updating GRUB 2 menu...
client> Failed to get blkid info for / on /dev/root at /nix/store/s54azprbp2ic2zpb7df2kb2pafmcrsdi-install-grub.pl line 185.
client> error: Traceback (most recent call last):
File "/home/teto/nixops/nixops/deployment.py", line 705, in worker
raise Exception("unable to activate new configuration")
Exception: unable to activate new configuration
==========
Solves
NixOS#32406
NixOS/nixops#795
|
This looks like a good change though I'm not very knowledgeable in the Linux stage stuff. /cc @domenkozar |
|
@matthewbauer thanks for the ping, If I deploy with a nixpkgs without this branch then I can't reboot the VM (that run with a host kernel) so that's annoying. |
|
Would love to have some feedback on this. The only drawback I see is the loss of some logging if /proc/cmdline was correctly mounted and boot.debugtrace set. It can be solved by duplicating the boot.debutrace but I thought the extra complexity was not worth it. |
teto
changed the title
|
This seems too peculiar a problem to justify the change, I'll try to work around it with boot.postCommands or fix it via a nixops patch instead. |
Motivation for this change
Solves (same problem)
#32406
NixOS/nixops#795
Create the symlink /dev/root in stage2 as in some cases (like when /proc is not available) stage 1 can't create it. I moved the /proc/cmdline parsing after /proc gets mounted.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)