rootston module: better defaults #33085
Conversation
|
Looks way better than my buggy draft, thanks 😄 Feel free to add yourself as a maintainer if you want to maintain this module as well 😉 (if not I'll merge it tomorrow). |
|
@primeos Done. Thanks for packaging wlroots and rootston! It makes it simple to track their progress. After I've seen that the fractional scaling works fine, I have a high hopes for forthcoming Sway-on-wlroots and will definately switch to it from my current i3 setup 😄 |
ghost
deleted the
| # Define a keymap (US QWERTY is the default) | ||
| export XKB_DEFAULT_LAYOUT=de,us | ||
| export XKB_DEFAULT_VARIANT=nodeadkeys | ||
| export XKB_DEFAULT_OPTIONS=grp:alt_shift_toggle,caps:escape |
There was a problem hiding this comment.
The preferred way to do this is in the config file.
There was a problem hiding this comment.
@emersion These options are (or were) not part of config. See e.g.
https://wiki.archlinux.org/index.php/Sway#Keymap
https://github.com/swaywm/sway/wiki#keyboard-layout
There was a problem hiding this comment.
@emersion Then feel free to fix it :-)
There was a problem hiding this comment.
Hi :) I think there was a bit of a misunderstanding.
@emersion I think you mean something like this (didn't check the syntax yet, just had a quick look at swaywm/wlroots#341)?:
[keyboard]
layout = de,us
variant = nodeadkeys
options = grp:alt_shift_toggle,caps:escapeI'll have a closer look (maybe open an upstream issue) and make a PR later. Thank you for letting us know how we can improve this module (wasn't aware that this is possible) 😄.
@gnidorah I assume (might be completely wrong) you where a bit "irritated" by the first comment (at least I initially was). @emersion is the main(?) wlroots developer and as I interpret his comment (now), is that he just wanted to help us. (Edit: And you're right these options where not part of the config at the time of this PR, i.e. it's the new "preferred" way.)
There was a problem hiding this comment.
Yeah, sorry, I really didn't mean to be irritating. I just stopped by and saw you're still using the Sway way, which is supported for legacy reasons. It's no big deal in the end, feel free to do whatever you want. :)
Motivation for this change
cc @primeos
Use weston-terminal instead of it. If you don't like weston-terminal, swap with termite (another wayland native). I mainly put weston-terminal because orbment and way-cooler use it by default.
Looks like wlroots author even uses gnome-terminal Add fractional scaling support swaywm/wlroots#488 (comment)
rofi works great for me as been suggested at Wayland menu for Sway? swaywm/sway#1367 (comment)
Useful to testing e.g. scaling in rootston. To ensure that all GTK3 programs will use configured font size and other settings.
BTW The reason why urxvt and dmenu are used in sway module is because default Sway configuration uses them.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)