Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ponyc: 0.21.0 -> 0.21.2 #33083

Closed
wants to merge 1 commit into from
Closed

ponyc: 0.21.0 -> 0.21.2 #33083

wants to merge 1 commit into from

Conversation

kamilchm
Copy link
Member

Motivation for this change

ponylang/ponyc#2448

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 26, 2017

@GrahamcOfBorg build ponyc

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

src/libponyrt/lang/posix_except.c:63:33: error: unknown type name '_Unwind_Context'
   _Unwind_Exception* exception, _Unwind_Context* context)
                                 ^~~~~~~~~~~~~~~
src/libponyrt/lang/posix_except.c:40:13: error: 'set_registers' defined but not used [-Werror=unused-function]
 static void set_registers(struct _Unwind_Exception* exception,
             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:783: build/release/obj/libponyrt/lang/posix_except.o] Error 1
builder for '/nix/store/ld5bya2yq9hpldjag2sjd112x7kz6ygr-ponyc-0.21.2.drv' failed with exit code 2
error: build of '/nix/store/ld5bya2yq9hpldjag2sjd112x7kz6ygr-ponyc-0.21.2.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

**** FAILED: 5 tests, listed below:
**** FAILED: net/TCP.writev
**** FAILED: net/TCP.expect
**** FAILED: net/TCPMute
**** FAILED: net/TCPUnmute
**** FAILED: net/TCPThrottle
Error: couldn't initialise runtime!
make: *** [Makefile:885: test-ci] Error 255
builder for '/nix/store/plxz60ym2db73q50bmby25nirgzbpyly-ponyc-0.21.2.drv' failed with exit code 2
error: build of '/nix/store/plxz60ym2db73q50bmby25nirgzbpyly-ponyc-0.21.2.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Writing ./examples.o
Linking ./examples1
All examples compile!
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xqxa1gi3zsblc0w3a2fasr4l97s851i7-ponyc-0.21.2
shrinking /nix/store/xqxa1gi3zsblc0w3a2fasr4l97s851i7-ponyc-0.21.2/lib/pony/0.21.2/bin/ponyc
patching script interpreter paths in /nix/store/xqxa1gi3zsblc0w3a2fasr4l97s851i7-ponyc-0.21.2
checking for references to /tmp/nix-build-ponyc-0.21.2.drv-0 in /nix/store/xqxa1gi3zsblc0w3a2fasr4l97s851i7-ponyc-0.21.2...
/nix/store/xqxa1gi3zsblc0w3a2fasr4l97s851i7-ponyc-0.21.2

@grahamc
Copy link
Member

grahamc commented Dec 26, 2017

@kamilchm are these aarch64 / darwin failures to be expected? LGTM otherwise.

@kamilchm
Copy link
Member Author

How can I rerun darwin/aarch64 builds? I can try to fix it.

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Dec 27, 2017 via email

@kamilchm
Copy link
Member Author

kamilchm commented Dec 28, 2017

I've updated patch for darwin tests and will try to fix arm build.

@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

ponyc was updated in #33471, somehow without changes to tests.

@orivej orivej closed this Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants