Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol: init at 20171226 #33065

Merged
merged 1 commit into from Dec 30, 2017
Merged

protocol: init at 20171226 #33065

merged 1 commit into from Dec 30, 2017

Conversation

teto
Copy link
Member

@teto teto commented Dec 26, 2017 •
edited

An ASCII Header Generator for Network Protocols http://www.luismg.com/protocol/

Run with $ protocol tcp for instance to see:

 0                   1                   2                   3  
 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|          Source Port          |        Destination Port       |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                        Sequence Number                        |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                     Acknowledgment Number                     |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| Offset|  Res. |     Flags     |             Window            |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|            Checksum           |         Urgent Pointer        |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                    Options                    |    Padding    |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner December 26, 2017 07:42
FRidh
FRidh reviewed Dec 26, 2017
View reviewed changes
pkgs/development/python-modules/protocol/default.nix Outdated
{ stdenv, buildPythonPackage, fetchFromGitHub }:

buildPythonPackage rec {
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in name will be autogenerated from pname/pversion ? I copy/pasted that from python-modules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of buildPython*, yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the line and force pushed

@teto
protocol: init at 20171226
0d3117b 
An ASCII Header Generator for Network Protocols http://www.luismg.com/protocol/

Run with `$ protocol tcp` for instance to see:

 0                   1                   2                   3
 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|          Source Port          |        Destination Port       |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                        Sequence Number                        |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                     Acknowledgment Number                     |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| Offset|  Res. |     Flags     |             Window            |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|            Checksum           |         Urgent Pointer        |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                    Options                    |    Padding    |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
@grahamc
Copy link
Member

grahamc commented Dec 27, 2017

@GrahamcOfBorg build python3Packages.protocol

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 27, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Testing Valid Spec 'Field_32:32,Field_16:16,Field_56:56?numbers=0'
Testing Valid Spec 'Field_32:32,Field_16:16,Field_32:32?numbers=0'
Testing Valid Spec 'Field_8:8,Field_8:8,Field_8:8,Field_8:8,Field_12:12,Field_17:17,Field_22:22,Field_8:8,Field_5:5?numbers=0'
Testing Valid Spec 'Field_16:16,Field_8:8,Field_8:8?numbers=0,bits=16'
Testing Valid Spec 'Field_16:16,Field_32:32?numbers=0,bits=16'
Testing Valid Spec 'Field_64:64?numbers=0,bits=16'
Testing Valid Spec 'Field_64:64?bits=64'
Testing Valid Spec 'Source Port:16,Destination Port:16,Sequence Number:32,Acknowledgment Number:32,Offset:4,Res.:4,Flags:8,Window:16,Checksum:16,Urgent Pointer:16,Options:24,Padding:8'
Testing Valid Spec 'Field_32:32?numbers=0,startchar=1,endchar=2,oddchar=3,evenchar=4,sepchar=5'
/nix/store/cbbmg69dznwm6jvbv4444wida7a9vawq-python3.6-protocol-20171226

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 27, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

Testing Valid Spec 'Field_32:32,Field_16:16,Field_56:56?numbers=0'
Testing Valid Spec 'Field_32:32,Field_16:16,Field_32:32?numbers=0'
Testing Valid Spec 'Field_8:8,Field_8:8,Field_8:8,Field_8:8,Field_12:12,Field_17:17,Field_22:22,Field_8:8,Field_5:5?numbers=0'
Testing Valid Spec 'Field_16:16,Field_8:8,Field_8:8?numbers=0,bits=16'
Testing Valid Spec 'Field_16:16,Field_32:32?numbers=0,bits=16'
Testing Valid Spec 'Field_64:64?numbers=0,bits=16'
Testing Valid Spec 'Field_64:64?bits=64'
Testing Valid Spec 'Source Port:16,Destination Port:16,Sequence Number:32,Acknowledgment Number:32,Offset:4,Res.:4,Flags:8,Window:16,Checksum:16,Urgent Pointer:16,Options:24,Padding:8'
Testing Valid Spec 'Field_32:32?numbers=0,startchar=1,endchar=2,oddchar=3,evenchar=4,sepchar=5'
/nix/store/jdv9fjd0synpfildkh60rm0h2klgx64z-python3.6-protocol-20171226

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 27, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

Testing Valid Spec 'Field_32:32,Field_16:16,Field_56:56?numbers=0'
Testing Valid Spec 'Field_32:32,Field_16:16,Field_32:32?numbers=0'
Testing Valid Spec 'Field_8:8,Field_8:8,Field_8:8,Field_8:8,Field_12:12,Field_17:17,Field_22:22,Field_8:8,Field_5:5?numbers=0'
Testing Valid Spec 'Field_16:16,Field_8:8,Field_8:8?numbers=0,bits=16'
Testing Valid Spec 'Field_16:16,Field_32:32?numbers=0,bits=16'
Testing Valid Spec 'Field_64:64?numbers=0,bits=16'
Testing Valid Spec 'Field_64:64?bits=64'
Testing Valid Spec 'Source Port:16,Destination Port:16,Sequence Number:32,Acknowledgment Number:32,Offset:4,Res.:4,Flags:8,Window:16,Checksum:16,Urgent Pointer:16,Options:24,Padding:8'
Testing Valid Spec 'Field_32:32?numbers=0,startchar=1,endchar=2,oddchar=3,evenchar=4,sepchar=5'
/nix/store/ap6s5f2rwzb5qmfszqk67j7w73nywzmv-python3.6-protocol-20171226

@FRidh FRidh merged commit 9ee22e2 into NixOS:master Dec 30, 2017
@teto teto deleted the protocol branch February 9, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @grahamc @FRidh @GrahamcOfBorg