qutebrowser: make gstreamer and pdfjs configurable #33074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval (sorry, an issue was introduced in to master which has since been fixed, really) |
|
I rebased the branch |
grahamc
reviewed
Dec 26, 2017
| , gst-plugins-good ? null | ||
| , gst-plugins-bad ? null | ||
| , gst-plugins-ugly ? null | ||
| , gst-libav ? null |
There was a problem hiding this comment.
No need for these to be ? null I think?
There was a problem hiding this comment.
I meant to add an assert !=null. I just gave a look at all-packages.nix: the package is called with arguments inherit (gst_all_1) [...] (and the same for python packages) so they are always defined? Is it good practice or should I remove it and use gst_all_1 inside the expression?
There was a problem hiding this comment.
If it's ok I'll squash the commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
PDF.js and gstreamer are optional dependencies in other distros.
I added two options to control these but kept the same behavior by default.
Also a small refactor.
Things done