init subdl package #33088
Merged
init subdl package #33088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
approved these changes
Dec 29, 2017
| buildInputs = [ python3 ]; | ||
|
|
||
| installPhase = '' | ||
| install -vD subdl $out/bin/subdl |
There was a problem hiding this comment.
install -Dt $out/bin subdl is even shorter :-)
| sha256 = "0kmk5ck1j49q4ww0lvas2767kwnzhkq0vdwkmjypdx5zkxz73fn8"; | ||
| }; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Nitpick: stdenv.lib could be omitted if meta was defined with stdenv.lib:
meta = with stdenv.lib; {
license = licenses.gpl3;
};
| { stdenv, fetchFromGitHub, python3 }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "subdl"; |
There was a problem hiding this comment.
It depends on reviewer, but some would only accept unversioned package with a date suffix in name, e.g. subdl-2017-12-30.
There was a problem hiding this comment.
Indeed, please put a version or at least date at the end. Otherwise, nix-env will never be able to update it.
|
@GrahamcOfBorg build subdl |
There was a problem hiding this comment.
Success for system: x86_64-linux
install: creating directory '/nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl'
install: creating directory '/nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl/bin'
'subdl' -> '/nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl/bin/subdl'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl
stripping (with flags -S) in /nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl/bin
patching script interpreter paths in /nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl
/nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl/bin/subdl: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/y95dd7cmw2xlf6hvg2j93b227pblpaaq-python3-3.6.4/bin/python3"
checking for references to /tmp/nix-build-subdl.drv-0 in /nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl...
/nix/store/1ib61gjdqqh6zvwifxfkdm9g5jgsk5rj-subdl
There was a problem hiding this comment.
Success for system: x86_64-darwin
no Makefile, doing nothing
installing
install: creating directory '/nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl'
install: creating directory '/nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl/bin'
'subdl' -> '/nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl/bin/subdl'
post-installation fixup
stripping (with flags -S) in /nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl/bin
patching script interpreter paths in /nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl
/nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl/bin/subdl: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/wqx2vx0cxqlmii5h907nkmgpi0p4n7vn-python3-3.6.4/bin/python3"
/nix/store/j5bdg2jj0b5fpaiqadf1pqbmb1a73r7m-subdl
There was a problem hiding this comment.
Success for system: aarch64-linux
install: creating directory '/nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl'
install: creating directory '/nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl/bin'
'subdl' -> '/nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl/bin/subdl'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl
stripping (with flags -S) in /nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl/bin
patching script interpreter paths in /nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl
/nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl/bin/subdl: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/0v219z55akk9lfaa1fv8987cr1if3wj9-python3-3.6.4/bin/python3"
checking for references to /build in /nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl...
/nix/store/g7mas7ix05dgz8gs96bfpaiii3r27jb0-subdl
|
LGTM and ready to merge once the version is added to the name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the subdl tool
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)