Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: 1.12.2 -> 1.12.3 #32477

Merged
merged 1 commit into from Dec 8, 2017
Merged

gstreamer: 1.12.2 -> 1.12.3 #32477

merged 1 commit into from Dec 8, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 8, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Dec 8, 2017

@GrahamcOfBorg eval

@orivej orivej changed the base branch from master to staging December 8, 2017 23:19
@orivej orivej merged commit 4fb4ab6 into NixOS:staging Dec 8, 2017
@orivej
Copy link
Contributor

orivej commented Dec 8, 2017

Merged into staging for better testing.

@magnetophon magnetophon deleted the gstreamer branch December 8, 2017 23:24
@@ -3,7 +3,7 @@
}:

stdenv.mkDerivation rec {
name = "gst-validate-1.12.2";
name = "gst-validate-1.12.3";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update the hash (and test apparently).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same holds also for -vaapi, -python, -editing-services.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: due to openssl security update, this now got to master, so any fixes should go there directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9ebcc8d

orivej added a commit that referenced this pull request Dec 11, 2017
@magnetophon
Copy link
Member Author

@vcunat @orivej Thanks, and sorry for the sloppiness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants