Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] neovim: 0.2.1 -> 0.2.2 #32509

Closed
wants to merge 4 commits into from
Closed

[WIP] neovim: 0.2.1 -> 0.2.2 #32509

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2017 •
edited by ghost

TODO
  - INFO: Ruby: ruby 2.4.0p0 (2016-12-24) [x86_64-linux]
  - INFO: Host: /nix/store/12l4jz2i1qw3hipzs6f016a1d0apm7fv-neovim-0.2.2/bin/nvim-ruby
  - ERROR: Command error (job=12): /nix/store/12l4jz2i1qw3hipzs6f016a1d0apm7fv-neovim-0.2.2/bin/nvim-ruby --version
    Output: /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/spec_set.rb:87:in `block in materialize': Could not find msgpack-1.1.0 in any of the sources (Bundler::GemNotFound)	from /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/spec_set.rb:80:in `map!'	from /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/spec_set.rb:80:in `materialize'	from /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/definition.rb:176:in `specs'	from /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/definition.rb:235:in `specs_for'	from /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/runtime.rb:19:in `setup'	from /nix/store/6z17cwrivy793q28q7sc0c4rh4349d0k-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler.rb:102:in `setup'	from /nix/store/12l4jz2i1qw3hipzs6f016a1d0apm7fv-neovim-0.2.2/bin/nvim-ruby:16:in `<main>'
  - ERROR: Failed to run: /nix/store/12l4jz2i1qw3hipzs6f016a1d0apm7fv-neovim-0.2.2/bin/nvim-ruby --version
    - ADVICE:
      - Report this issue with the output of: 
      - /nix/store/12l4jz2i1qw3hipzs6f016a1d0apm7fv-neovim-0.2.2/bin/nvim-ruby --version
Motivation for this change

Especially important, because v0.2.1 contains broken netrw parts, which is fixed in v0.2.2 (neovim/neovim#7557).

And of course the new version contains in general bug fixes and new features (-> Release Notes)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej changed the title [WIP] v0.2.1 -> 0.2.2 [WIP] neovim: 0.2.1 -> 0.2.2 Dec 9, 2017
@teto
Copy link
Member

teto commented Dec 11, 2017

I am preparing a neovim wrapper (to prevent useless rebuilds) and while doing so I noticed the withPython3 instead of withRuby here:
https://github.com/toogley/nixpkgs/blob/f7f940cf7156994d30bdb97582dd48bd1a9dffc8/pkgs/applications/editors/neovim/default.nix#L146
Could you fix it too as well please ?

@teto
Copy link
Member

teto commented Dec 26, 2017

Is it still WIP ? I've kinda finished my wrapper so I wonder if I should wait for your PR first.

@ghost
Copy link
Author

ghost commented Dec 26, 2017 •
edited by ghost

@teto Yep, its still WIP and i'm not sure how long it takes to finish this PR.

@mnacamura
Copy link
Contributor

I succeeded in building on macOS and passing :CheckHealth by adding the following changes to this PR:

diff --git a/pkgs/applications/editors/neovim/ruby_provider/Gemfile.lock b/pkgs/applications/editors/neovim/ruby_provider/Gemfile.lock
index 61df9ed7932..07426ace850 100644
--- a/pkgs/applications/editors/neovim/ruby_provider/Gemfile.lock
+++ b/pkgs/applications/editors/neovim/ruby_provider/Gemfile.lock
@@ -1,9 +1,9 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    msgpack (1.1.0)
+    msgpack (1.2.0)
     multi_json (1.12.2)
-    neovim (0.6.1)
+    neovim (0.6.2)
       msgpack (~> 1.0)
       multi_json (~> 1.0)

@teto
Copy link
Member

teto commented Jan 17, 2018

Could you rebase please ? you might need to edit pkgs/applications/editors/neovim/wrapper.nix

@jlesquembre jlesquembre mentioned this pull request Jan 21, 2018
Merged
8 tasks
@jlesquembre
Copy link
Member

I think we can close this PR since #34113 is already merged

@ghost ghost closed this Feb 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @mnacamura @jlesquembre @GrahamcOfBorg