Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik: 3.2.0 -> 3.2.1 #32493

Merged
merged 1 commit into from Dec 9, 2017
Merged

piwik: 3.2.0 -> 3.2.1 #32493

merged 1 commit into from Dec 9, 2017

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

Bug fixes & security updates: https://piwik.org/changelog/piwik-3-2-1/

Please backport to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb srhb merged commit 4976020 into NixOS:master Dec 9, 2017
@srhb
Copy link
Contributor

srhb commented Dec 9, 2017

The version in stable is the 3.1 branch, not the 3.2 branch. Should this really be backported?

@srhb srhb mentioned this pull request Dec 9, 2017
Merged
8 tasks
@florianjacob
Copy link
Contributor Author

@srhb yes, this should indeed be backported, please! When I did the 3.2 release update, I did not notice it was not backported to stable, sorry.

Piwik only supports & update the most recent minor version of 2.X and 3.X - they use minor version vs patchlevel just to indicate whether any new features have landed or it's really just bug fixes and security updates.

@florianjacob florianjacob deleted the piwik-3.2.1 branch December 9, 2017 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianjacob @srhb @GrahamcOfBorg