Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lv2 plugins #32487

Merged
merged 3 commits into from Dec 11, 2017
Merged

Lv2 plugins #32487

merged 3 commits into from Dec 11, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 8, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Dec 8, 2017

@GrahamcOfBorg eval

@magnetophon
Copy link
Member Author

@orivej Is there anything wrong with this PR?

@orivej orivej merged commit 9bcffa5 into NixOS:master Dec 11, 2017
@magnetophon magnetophon deleted the lv2-plugins branch December 11, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @LnL7 @orivej @GrahamcOfBorg