Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsynth: 0.3.9 -> 0.4.4 #32468

Merged
merged 1 commit into from Dec 9, 2017
Merged

qsynth: 0.3.9 -> 0.4.4 #32468

merged 1 commit into from Dec 9, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 8, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Dec 8, 2017

Please use libsForQt5 (see examples in all-packages.nix) and put cmake, pkgconfig in nativeBuildInputs.

@magnetophon
Copy link
Member Author

@orivej cmake and pkgconfig are moved.
I've looked at a couple of examples for libsForQt5, but I don't see the pattern yet.
Could you explain?

Thanks for all the quick merges!

@orivej
Copy link
Contributor

orivej commented Dec 8, 2017

You are welcome! See https://nixos.org/nixpkgs/manual/#ssec-qt-applications:

Call your application expression using libsForQt5.callPackage instead of callPackage. Import dependencies unqualified, i.e., qtbase not qt5.qtbase. Do not import a package set such as qt5 or libsForQt5.

@magnetophon
Copy link
Member Author

@orivej Thanks!
Done.

@Mic92 Mic92 merged commit 398478d into NixOS:master Dec 9, 2017
@magnetophon magnetophon deleted the qsynth branch December 9, 2017 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @orivej @Mic92 @GrahamcOfBorg