Don't set cxx_stdlib when nativeTools on linux #32498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 9, 2017
| @@ -46,7 +46,7 @@ let | |||
| # The wrapper scripts use 'cat' and 'grep', so we may need coreutils. | |||
| coreutils_bin = if nativeTools then "" else getBin coreutils; | |||
|
|
|||
| default_cxx_stdlib_compile=optionalString (targetPlatform.isLinux && !(cc.isGNU or false)) | |||
| default_cxx_stdlib_compile=optionalString (!nativeTools && targetPlatform.isLinux && !(cc.isGNU or false)) | |||
There was a problem hiding this comment.
gcc should usually not receive these arguments because of !cc.isGNU. Do you mean clang?
There was a problem hiding this comment.
Do I mean clang where? In this case it's just about when cc is null (so we don't really know what the compiler is).
There are no gcc paths on nativeTools, and cc isn't set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no gcc paths with nativeTools, and cc isn't set.
When attempting to use nativeTools on linux, an error is produced trying to expand
cc.gccto setdefault_cxx_stdlib_compile. I'm guessing this would only happen on obscure unsupported linux architectures. In this case, however, I purposefully want to use nativeTools for a special build, so I'm using:which produces:
If there is a better way to make this work (creating a native tools-based stdenv on linux), that's fine, too.
I realize there are reasons against and risks in doing this, but it is not meant to build a full system.
I don't believe this will break any normal use case, but I'm not entirely sure.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)