Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fftw: 3.3.6-pl1 -> 3.3.7 #32476

Merged
merged 1 commit into from Dec 8, 2017
Merged

fftw: 3.3.6-pl1 -> 3.3.7 #32476

merged 1 commit into from Dec 8, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 8, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Dec 8, 2017

Could you fix the version number in the commit message (and in the title of the PR)?

@magnetophon
Copy link
Member Author

@orivej oops. done.

@orivej
Copy link
Contributor

orivej commented Dec 8, 2017

@GrahamcOfBorg eval

1 similar comment
@grahamc
Copy link
Member

grahamc commented Dec 8, 2017

@GrahamcOfBorg eval

@magnetophon
Copy link
Member Author

@orivej @grahamc I'm not sure what ofborg is yet, but while reading the readme, I saw:

be gentle, preferably don't run mass rebuilds / massive builds like chromium on it

This triggers all browsers + libreoffice, plus other stuff.
Last time I updated this, I marked it as mass-rebuild, but that was considered over the top then, but you might want to reconsider ofborg.

I'll go back to reading what ofborg actually is now... ;)

@orivej orivej changed the title fftw: 3.3.6-pl1 -> 0.3.3.7 fftw: 3.3.6-pl1 -> 3.3.7 Dec 8, 2017
@grahamc
Copy link
Member

grahamc commented Dec 8, 2017

ofborg is two things: 1. it runs builds (by request, ie: @grahamcofborg build foobar will have it build foobar and report the results.) the second is it automatically runs eval checks ... but I was a dinkus and accidentally ran a beta version which marked all your PRs as broken :) eval can / does run on every PR ,regardless of mass rebuild status.

@orivej orivej changed the base branch from master to staging December 8, 2017 21:51
@orivej orivej merged commit 870690f into NixOS:staging Dec 8, 2017
@magnetophon
Copy link
Member Author

@grahamc thanks. so it's kind of the nixos version of travis?

@grahamc
Copy link
Member

grahamc commented Dec 8, 2017 via email

@magnetophon magnetophon deleted the fftw branch January 25, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @orivej @grahamc @GrahamcOfBorg