Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mstpd: svn 61 -> 0.0.5.20171113 #32313

Merged
merged 1 commit into from Dec 8, 2017
Merged

mstpd: svn 61 -> 0.0.5.20171113 #32313

merged 1 commit into from Dec 8, 2017

Conversation

andir
Copy link
Member

@andir andir commented Dec 4, 2017 •
edited

Also fetches package from it's new home on GitHub and fixes compilation
with gcc-7 (#31747).

CC @wkennington the current maintainer

Motivation for this change

Package has been moved to GitHub a while ago & fixes for gcc-7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Instead of using part of the git rev for the version (which is how a lot of packages are doing it admittedly), please use the date of the commit instead as nix-env -u will not otherwise see things as an update.

That also means you can get rid of the rev stuff.

So version would be 0.0.5.20170101 (or whatever the date is).

@andir andir changed the title mstpd: svn 61 -> 0.0.5-g2522c6e mstpd: svn 61 -> 0.0.5.2017.11.13 Dec 7, 2017
@andir andir changed the title mstpd: svn 61 -> 0.0.5.2017.11.13 mstpd: svn 61 -> 0.0.5.20171113 Dec 7, 2017
@andir
mstpd: svn 61 -> 0.0.5.20171113
8ab4eb1 
Also fetches package from it's new home on GitHub and fixes compilation
with gcc-7 (NixOS#31747).
@andir
Copy link
Member Author

andir commented Dec 7, 2017

@peterhoeg thanks for the remarks. Should be good now

@peterhoeg peterhoeg merged commit 9dee38e into NixOS:master Dec 8, 2017
@andir andir deleted the mstpd-to-github-0.0.5 branch December 8, 2017 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @peterhoeg @GrahamcOfBorg