Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: add 7.2.0 #32305

Merged
merged 3 commits into from Jan 1, 2018
Merged

php: add 7.2.0 #32305

merged 3 commits into from Jan 1, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 4, 2017

Motivation for this change

New big release of PHP. Added as alternative.

Don't know if I missed anything important, please point out things so I can update it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Changelog entry should be added to https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1803.xml
Doesn`t have to be any more than 7e5424a

php72Packages should also be added.

@etu etu changed the title php: 7.1.11 -> 7.2.0 [WIP] php: 7.1.11 -> 7.2.0 Dec 5, 2017
@etu etu changed the title [WIP] php: 7.1.11 -> 7.2.0 php: 7.1.11 -> 7.2.0 Dec 27, 2017
@etu etu changed the title php: 7.1.11 -> 7.2.0 php: add 7.2.0 Dec 27, 2017
@etu etu force-pushed the php72 branch 4 times, most recently from d854c7d to 74a2209 Compare January 1, 2018 17:51
Earlier versions doesn't work with PHP 7.2.
@adisbladis adisbladis merged commit f59a0f7 into NixOS:master Jan 1, 2018
@etu etu deleted the php72 branch January 1, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants