kicad: init unstable at version 2017-12-11 #32648
Conversation
|
I took the liberty of adding @viric as a maintainer. Please approve :-) |
berce
force-pushed
the
upstream-kicad
branch
from
14f3fd4
to
dc884b4
Compare
| @@ -0,0 +1,52 @@ | |||
| { config, wxGTK, lib, pkgs, stdenv, fetchFromGitHub, cmake, mesa, zlib | |||
There was a problem hiding this comment.
configis not usedpkgsshould be removed
There was a problem hiding this comment.
Done locally.
Should I squash it in the previous commit to update the PR, or add a new commit?
pkgs/top-level/all-packages.nix
Outdated
| @@ -19017,6 +19017,12 @@ with pkgs; | |||
| boost = boost160; | |||
| }; | |||
|
|
|||
| kicad-unstable = callPackage ../applications/science/electronics/kicad/unstable.nix { | |||
There was a problem hiding this comment.
KiCad optionally uses python for scripting. It is not a python application.
Is this change still required?
Also no other package in top-level.nix uses the proposed code.
There was a problem hiding this comment.
there are a few that use pythonPackages.callPackage which is the same.
Yes, this should be used. Top-level packages should not have any inherit (pythonPackages) foo; as that risks mixing Python 2 and 3 packages (which was a common issue 3+years ago).
There was a problem hiding this comment.
Then I 'll use pythonPackages.callPackagefor uniformity. Unless you object.
If you object, I propose to also change the others in a separate PR.
pkgs/top-level/all-packages.nix
Outdated
| kicad-unstable = callPackage ../applications/science/electronics/kicad/unstable.nix { | ||
| wxGTK = wxGTK30; | ||
| boost = boost160; | ||
| inherit (pythonPackages) wxPython; |
There was a problem hiding this comment.
Leaving out the wxGTK = wxGTK30 line makes it default to wxGTK28. Even when using python.pkgs.callPackage. Then compiling fails due to finding wxwidgets 2.8.12 and at least 3.0.0 is required.
There was a problem hiding this comment.
I was referring only to
inherit (pythonPackages) wxPython;
There was a problem hiding this comment.
If you meant removing just the last line (inherit...), it seems to compile well.
wxPython related build problems only appear at 75% of compiling, so it 'll take some time to have full confirmation.
berce
force-pushed
the
upstream-kicad
branch
2 times, most recently
from
333d4e7
to
c09336e
Compare
|
All proposed changes have been applied. |
orivej
force-pushed
the
upstream-kicad
branch
from
c09336e
to
862a6dd
Compare
orivej
force-pushed
the
upstream-kicad
branch
from
862a6dd
to
f314157
Compare
Motivation for this change
Files are not forward compatible, so when cooperating with someone who needs features of the Nightly Development Build, you also need this newer version.
In contrast with the current package for the stable release of KiCad, this package also enables oce, ngspice and scripting support.
This package does not provide the component libraries (schematics, PCB footprints, 3D models). They can be obtained from KiCad, unpacked and referenced at runtime.
It is called unstable and not nightly because it doesn't automatically track upstream nightly development builds.
wxPython headers are needed at buildtime. This PR includes a necessary change to wxPython. That change is also in a separate PR: #32647
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)