Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuke openstack (again) #32637

Merged
merged 9 commits into from Dec 15, 2017
Merged

nuke openstack (again) #32637

merged 9 commits into from Dec 15, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Dec 13, 2017

Motivation for this change

openstack packaging in nixpkgs is a mess, not to mention the security issues it produces once people actually want to use it.
This PR tries to progressively remove the parts of openstack and tries to avoid conflicts.
Ref: #29491

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

part of openstack cleanup
@makefu
Copy link
Contributor Author

makefu commented Dec 13, 2017

okay done

@makefu makefu changed the title [WIP] nuke openstack (again) nuke openstack (again) Dec 13, 2017
name = "oslosphinx-3.3.1";
rfc3986 = callPackage ../development/python-modules/rfc3986 { };

cachetools_1 = callPackage ../development/python-modules/cachetools/1.nix {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation?

Copy link
Contributor Author

@makefu makefu Dec 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, i fix this commit.

EDIT: i think the github preview fucked this part up. Diff looks ok in git cli

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think at some point the indentation is also incorrect in python-packages.nix already before these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i saw weird indentation in the python-packages.nix but i haven't touched it to keep the PR clean.

keystone = 265;
glance = 266;
# keystone = 265; # unused
# glance = 266; #unused
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use unused when only either group id or user id is unused.

Copy link
Contributor Author

@makefu makefu Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i thought it was for showing that there are still unused numbers from old packages in this sections which are up for grabs. i can keep 2 empty lines instead

EDIT: i re-checked and it seems that a couple of obsolete entries simply have a remark when the package was removed

Copy link
Member

@Mic92 Mic92 Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then please add that remark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay done

part of openstack cleanup
part of openstack cleanup
part of openstack cleanup
part of openstack cleanup
pyrax: rip
rackspace-novaclient: rip
openstackclient: rip
  ironicclient: rip
barbicanclient: rip
  castellan: rip
cinderclient: rip
neutronclient: rip
glanceclient: rip
keystonemiddleware: rip
oslo-vmware: rip
oslo-serialization: rip
  pycadf: rip
  os-brick: rip
  taskflow: rip
oslo-utils: rip
oslo-middlewar: rip
oslo-versionedobjects: rip
oslo-messaging: rip
oslo-reports: rip
oslo-db: rip
oslo-rootwrap: rip
oslo-service: rip
oslo-cache: rip
oslo-config: rip
  glance_store: rip
  networking-hyperv: rip
  ryu: rip
  keystoneauth1: rip
    os-client-config: rip
oslo-log: rip
  tempest-lib: rip
oslo-context: rip
oslo-i18n: rip
oslotest: rip
  futurist: rip
  bandit: rip
  cliff: rip
    cliff-tablib: rip
oslosphinx: rip
  osprofile: rip
  os-testr: rip
  stevedore: remove oslosphinx from buildInputs
oslo-policy: rip
oslo-concurrency: rip

unused packages:
  swiftclient: rip
  debtcollector: rip
    automaton: rip
@Mic92 Mic92 merged commit 5687f61 into NixOS:master Dec 15, 2017
@Mic92
Copy link
Member

Mic92 commented Dec 15, 2017

Thanks!

@makefu
Copy link
Contributor Author

makefu commented Dec 15, 2017

thanks! maybe a short remark should be added to the release notes

@FRidh FRidh mentioned this pull request Dec 16, 2017
2 tasks
@makefu makefu deleted the pkgs/openstack/nuke branch August 4, 2020 15:32
@emilytrau emilytrau mentioned this pull request Aug 16, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants