New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nuke openstack (again) #32637
nuke openstack (again) #32637
Conversation
e903350
to
e424514
Compare
6448679
to
b52e6ae
Compare
okay done |
name = "oslosphinx-3.3.1"; | ||
rfc3986 = callPackage ../development/python-modules/rfc3986 { }; | ||
|
||
cachetools_1 = callPackage ../development/python-modules/cachetools/1.nix {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, i fix this commit.
EDIT: i think the github preview fucked this part up. Diff looks ok in git
cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think at some point the indentation is also incorrect in python-packages.nix
already before these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i saw weird indentation in the python-packages.nix
but i haven't touched it to keep the PR clean.
nixos/modules/misc/ids.nix
Outdated
keystone = 265; | ||
glance = 266; | ||
# keystone = 265; # unused | ||
# glance = 266; #unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use unused
when only either group id or user id is unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, i thought it was for showing that there are still unused
numbers from old packages in this sections which are up for grabs. i can keep 2 empty lines instead
EDIT: i re-checked and it seems that a couple of obsolete entries simply have a remark when the package was removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then please add that remark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay done
part of openstack cleanup
part of openstack cleanup
part of openstack cleanup
part of openstack cleanup
pyrax: rip rackspace-novaclient: rip openstackclient: rip ironicclient: rip
barbicanclient: rip castellan: rip cinderclient: rip neutronclient: rip glanceclient: rip keystonemiddleware: rip
oslo-vmware: rip oslo-serialization: rip pycadf: rip os-brick: rip taskflow: rip oslo-utils: rip oslo-middlewar: rip oslo-versionedobjects: rip oslo-messaging: rip oslo-reports: rip oslo-db: rip oslo-rootwrap: rip oslo-service: rip oslo-cache: rip oslo-config: rip glance_store: rip networking-hyperv: rip ryu: rip keystoneauth1: rip os-client-config: rip oslo-log: rip tempest-lib: rip oslo-context: rip oslo-i18n: rip oslotest: rip futurist: rip bandit: rip cliff: rip cliff-tablib: rip oslosphinx: rip osprofile: rip os-testr: rip stevedore: remove oslosphinx from buildInputs oslo-policy: rip oslo-concurrency: rip unused packages: swiftclient: rip debtcollector: rip automaton: rip
use fetchPypi instead of fetchurl
b52e6ae
to
1c870ef
Compare
Thanks! |
thanks! maybe a short remark should be added to the release notes |
Motivation for this change
openstack packaging in nixpkgs is a mess, not to mention the security issues it produces once people actually want to use it.
This PR tries to progressively remove the parts of openstack and tries to avoid conflicts.
Ref: #29491
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)