Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-cash: 2.9.4 -> 3.0 #32642

Merged
merged 1 commit into from Dec 18, 2017
Merged

electron-cash: 2.9.4 -> 3.0 #32642

merged 1 commit into from Dec 18, 2017

Conversation

rycee
Copy link
Member

@rycee rycee commented Dec 13, 2017

Motivation for this change

To bump electron-cash to latest version. Note, this version requires Python 3 and Qt5. I'm not certain the QT_QPA_PLATFORM_PLUGIN_PATH setting is OK.

Maintainer CC: @Lassulus

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

I too am interested in how to properly setup the QT plugin path. The electrum package just crashes unless QT_PLUGIN_* is set appropriately. The expressions should be harmonized, I think or even unified if possible.

@Mic92
Copy link
Member

Mic92 commented Dec 14, 2017

@ttuegel do you have insights on correct usage of QT_PLUGIN_* variables?

@ttuegel
Copy link
Member

ttuegel commented Dec 14, 2017

do you have insights on correct usage of QT_PLUGIN_* variables?

They should not be set. They will be set correctly when installed on NixOS or with nix-env. (This means, unfortunately, that Qt applications do not work with nix-build or nix-shell.) If set at build-time, the application tends to integrate poorly with non-KDE and non-NixOS systems.

@joachifm
Copy link
Contributor

Hrm, then I'll leave the original electrum as it is, though it is kind of poor ux to crash out-of-the-box if running directly from nixpkgs. Then again, it's simple enough to fix if you know how to ... @ttuegel I'm still a little unclear why it is that there were no problems of this kind with qt4? Simply a change in architecture between qt4 and 5?

@rycee
Copy link
Member Author

rycee commented Dec 15, 2017

Thanks, that is good to know! I've force pushed a version without the QT_QPA_PLATFORM_PLUGIN_PATH variable. I verified that it does indeed run OK if I install the package to my profile.

@ttuegel
Copy link
Member

ttuegel commented Dec 17, 2017

I'm still a little unclear why it is that there were no problems of this kind with qt4? Simply a change in architecture between qt4 and 5?

Qt 4 didn't use plugins this way while Qt 5 makes extensive use of plugins. We also only ever shipped one version of Qt 4 at a time, but we ship multiple Qt 5 versions; we must be very careful about plugin compatibility. We could (and once did) use wrappers to take care of this; then programs work the way developers expect, but not the way that users expect. So this was my compromise between developer and user experience. I don't like it, but I don't know how to do better right now. ☹️

@Mic92 Mic92 merged commit fe94055 into NixOS:master Dec 18, 2017
@rycee rycee deleted the bump/electron-cash branch December 18, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants