Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-lib: evaluate nixpkgs on armv6l and armv7l #32641

Merged
merged 1 commit into from Dec 30, 2017

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Dec 13, 2017

Motivation for this change

I am experimenting with Hydra and armv7l, and I found that release-lib.nix does not evaluate nixpkgs for armv7l. This PR adds support for armv7l as well as armv6l to release-lib.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

cc @grahamc

@grahamc
Copy link
Member

grahamc commented Dec 26, 2017

cc @dezgeg

@flokli
Copy link
Contributor

flokli commented Dec 30, 2017

Really looking forward to see more armv7l support!

Since christmas, I found time to take a look at some of my arm boards, which would clearly benefit from better support in NixOS.

Adding builds for those architectures to hydra would help a lot to track down build failures.

/cc @dezgeg

@dezgeg dezgeg merged commit b1a2e1c into NixOS:master Dec 30, 2017
@lopsided98 lopsided98 deleted the arm-release-lib branch January 1, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants