Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cutemaze: init at 1.2.1 #32646

Merged
merged 2 commits into from Dec 14, 2017
Merged

cutemaze: init at 1.2.1 #32646

merged 2 commits into from Dec 14, 2017

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jb55
jb55 approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@orivej orivej closed this Dec 14, 2017
@orivej orivej reopened this Dec 14, 2017
@orivej
Copy link
Contributor

orivej commented Dec 14, 2017

I have added a missing dependency on qttools (translations were not building) and added support for darwin (upstream does not define what to install on Darwin).

@dotlambda
Copy link
Member Author

Thank you, @orivej!

@orivej orivej merged commit 502bc9b into NixOS:master Dec 14, 2017
@dotlambda dotlambda deleted the cutemaze branch February 8, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @orivej @jb55 @GrahamcOfBorg