Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS support for KeePassXC package #32879

Closed
wants to merge 2 commits into from
Closed

Add macOS support for KeePassXC package #32879

wants to merge 2 commits into from

Conversation

ariutta
Copy link
Contributor

@ariutta ariutta commented Dec 20, 2017 •
edited

Motivation for this change

Make the KeePassXC package work on macOS in addition to Linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 20, 2017

@GrahamcOfBorg build keepassx-community

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 20, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4620  100  4620    0     0   4620      0  0:00:01 --:--:--  0:00:01 27664

fetching path ‘/nix/store/gw9gvs67jfhr5s6dc2xi75bmn2yc4440-keepassxc-2.2.4’...

*** Downloading ‘https://cache.nixos.org/nar/1i6x1lfc1zfa846nhq4a3s67lbhn2a7mgdglnvg9xdfkqwqw8x47.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/gw9gvs67jfhr5s6dc2xi75bmn2yc4440-keepassxc-2.2.4’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2095k  100 2095k    0     0  2095k      0  0:00:01 --:--:--  0:00:01 3114k

/nix/store/gw9gvs67jfhr5s6dc2xi75bmn2yc4440-keepassxc-2.2.4

@orivej orivej self-assigned this Dec 20, 2017
@bjornfor
Copy link
Contributor

Please prefix commit messages with "keepassxc: ...".

@orivej orivej closed this in b693f98 Dec 20, 2017
@orivej
Copy link
Contributor

orivej commented Dec 20, 2017 •
edited

I have added support for macOS in b693f98 and proposed a fix for No known features for CXX compiler "Clang" version 4.0.1. upstream: keepassxreboot/keepassxc#1308 (already merged). I have opted for the app bundle packaging: the app will show in the launcher if ~/Applications is a link to (or contains links into) ~/.nix-profile/Applications. (It can still be launched from console with open -a keepassxc. However, both the dock and the open command have severe cache invalidation issues and it was taking me some effort to convince them that they should stop running old binaries after reinstallations of the application. Nevertheless, the first installation is smooth.)

@orivej
Copy link
Contributor

orivej commented Dec 20, 2017

I have also added macdeployqt to qttools on darwin in fb349c8 (on staging branch) because it was confusing not to have it, even though with Nixpkgs keepassxc is better without it (because it copies all dependent libraries into the application directory). (It would be nice to upstream an option to disable the use of macdeployqt in keepassxc.)

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 20, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Merge failed

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 20, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Merge failed

drdaeman pushed a commit to drdaeman/nixpkgs that referenced this pull request Mar 4, 2018
@orivej @drdaeman
keepassxc: support macOS
51e4f13 
Closes NixOS#32879, taking the new description from the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees

@orivej orivej

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ariutta @grahamc @bjornfor @orivej @GrahamcOfBorg @Janik-Haag