welle-io: init at 1.0-rc1 #32865
Merged
welle-io: init at 1.0-rc1 #32865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
reviewed
Dec 21, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -14909,6 +14909,8 @@ with pkgs; | |||
|
|
|||
| wavrsocvt = callPackage ../applications/misc/audio/wavrsocvt { }; | |||
|
|
|||
| welle-io = qt5.callPackage ../applications/misc/welle-io { }; | |||
There was a problem hiding this comment.
Please use libsForQt5.callPackage. It is different from qt5.callPackage , which is not meant for use outside of the definition of Qt.
| ]; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig ]; | ||
|
|
There was a problem hiding this comment.
I'd appreciate if attributes were in the familiar order: nativeBuildInputs, buildInputs, cmakeFlags, enableParallelBuilding (which is now the default for cmake, qmake and meson projects).
|
Thanks a lot for reviewing. I updated the PR. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)