Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx service: Make http2 an option. #32858

Merged
merged 1 commit into from Dec 20, 2017
Merged

nginx service: Make http2 an option. #32858

merged 1 commit into from Dec 20, 2017

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 19, 2017

HTTP 2 can break some things, for example due to this Chrome bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=796199

So the service hardcoding it to be enabled is not helpful.

This commit adds an option so you can turn it off.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Fits CONTRIBUTING.md.
  • Tested in my nginx staging deployment

CC @fpletz @globin

@nh2
nginx service: Make http2 an option.
afa97cb 
HTTP 2 can break some things, for example due to this Chrome bug:

  https://bugs.chromium.org/p/chromium/issues/detail?id=796199

So the service hardcoding it to be enabled is not helpful.

This commit adds an option so you can turn it off.
fpletz
fpletz approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 👍

@fpletz
Copy link
Member

fpletz commented Dec 19, 2017

We should IMHO also backport this simple new option to 17.09.

@fpletz fpletz merged commit cf12bc4 into NixOS:master Dec 20, 2017
@hrdinka hrdinka mentioned this pull request Dec 27, 2017
Merged
8 tasks
@nh2
Copy link
Contributor Author

nh2 commented Feb 14, 2018

HTTP 2 can break some things, for example due to this Chrome bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=796199

It turned out not to be a bug in Chrome, but in nginx. The bug now contains updated information.

I'll open an issue to discuss whether we should change an nginx setting that works around this, as it is affecting all browsers and HTTP/2 is on by default on NixOS.

@nh2 nh2 mentioned this pull request Feb 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @fpletz @GrahamcOfBorg