release.nix: use 'nixpkgs' argument, even if nixpkgs in NIX_PATH #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 cc @edolstra |
|
I had a more complete version of this in my git stash that I've pushed instead (6d80870). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use custom Nix (upstream with my outstanding PR's optimistically merged),
I noticed that overriding the
nixpkgsargument torelease.nixdoesn't seem to have any impact.At least not if
nixpkgsis onNIX_PATH(which it usually isn't on Hydra).Concretely this caused Nix to fail to build since my system's
nixpkgsdoesn't have the new aws bits (I'm on 17.09).The default value for the argument reads from NIX_PATH and seems to work (happily no recursive definition problems?),
so thought I'd submit it to y'all in case it seems like a good change.