Actually my machines run out of memory (?) when trying to use nox-review O:). On a 32GB node.

None of the following is relevant to this PR!

Turns out huge rebuilds and nox-review and nix-build don't play nice, resulting in a PR I just filed against nox. Weeee.

Looks like memory exhaustion was due to boehmgc, message below :(. Chasing a bit suggests perhaps building with large config enabled might help?

Too many heap sections: Increase MAXHINCR or MAX_HEAP_SECTS

Update:

Looks like boehmgc's "small" (default) config is at 8GB which matches that I'm seeing before nix reports the above error.

Update 2:

Looks like the sort of command nox-review uses (nix-build -A attr1 -A attr2 ...) causes Nix to use a lot of memory!
Seeing the memory error (8GB used) when using only ~10% of the attributes it generates to review this PR O:).

Replacing the command with a single expression with all the attributes in an array fixes the memory usage!

Might not be perfect, but for completeness here's what I mean:

$ nix-build -E - <<EOF
  let e = import /home/will/.nox/nixpkgs { };
  in [
    e.openscad
    e.kdeFrameworks.kidletime
    e.python36Packages.secretstorage
    e.cherrytree
    e.firefoxWrapper
    e.haxe
    e.virtmanager
    e.ibus-engines.libpinyin
    e.kdeApplications.l10n.zh_TW.qt4
    e.toxic
    e.inkscape
    e.kdeApplications.akonadi-contacts
    e.kdeApplications.l10n.el.qt4
    e.gnome3.gnome-bluetooth
    e.moonlight-embedded
    e.eid-viewer
    e.cataclysm-dda
    e.libvirt
    e.libsForQt5.modemmanager-qt
    e.cataclysm-dda-git
    e.debian_devscripts
    e.hash-slinger
    e.fcitx-engines.unikey
    ...
    e.kdeApplications.konsole
    e.zeal
    e.xfce.xfce4_pulseaudio_plugin
    e.libsForQt5.libdbusmenu
    e.dotnetPackages.OpenNAT
    e.seyren
    e.jing
    e.gnome2.libgnomeprint
    e.asciidoc-full-with-plugins
    e.libsForQt5.kitemviews
    e.jfbview
    e.sound-juicer
    e.envoy
    e.git-crypt
    e.dleyna-renderer
    e.libsForQt56.libopenshot
    e.synthv1
    e.numix-sx-gtk-theme
    e.kdeApplications.libkcddb
]
EOF

Ping! @LnL7 is this something you can look into, or maybe ping someone who can? Thanks! :D

I have tested on Darwin by building llvm_5, clang_5 and ycmd (it uses llvmPackages_5). Thanks for the update!

Forgot about this, thanks for the ping 😄

I initially forgot – the Darwin stdenv uses an older branch than 5, so the Darwin impact should be minimal anyway...

Yeah, perhaps we should start looking at switching the default.