For reference: https://github.com/koalaman/shellcheck/wiki/SC1117

Since this is a stylistic change, I think that in order for it to make sense this also should be changed in the rest of Nixpkgs, preferably including .nix files.

Or we could disable this check. I’m just trying to unblock the unstable channels.

@acowley I'm sorry, I was wrong.

I should have looked into the derivation before making assumptions.

I don't know if this is necessary or sufficient to unstuck the channel, but at least it fixes the test.

I thought that http://hydra.nixos.org/job/nixos/trunk-combined/tested linked from https://howoldis.herokuapp.com/ is responsible for channel updates, but it has completed 6 hours ago and the channel has not advanced.

Does Hydra build with checks, even if doCheck = false by default?

Aha, I was looking at nixos-unstable (the default channel on NixOS) and @acowley was looking at nixpkgs-unstable.

@yegortimoshenko No.

Then this has not affected the channel, see: https://github.com/nixos/nixpkgs/blob/2e001620d52ddbaa41fcd5ab8dfb5e36d204ea1c/pkgs/tools/nix/info/default.nix#L2

I didn't think that nix-info derivation used shellcheck, so I was wrong in my first comment anyway.

It is an option to be overridden :)

...

https://howoldis.herokuapp.com/ gives an explanation:

For a channel to be updated two conditions need to be satisfied:

• Particular jobset evaluation needs to be completely built ie. no more queued jobs, even if some jobs may fail
• Particular jobset evaluation's tested/unstable job needs to be built succesfully

And the evaluation of that nixos-unstable jobset has not completed yet: https://hydra.nixos.org/eval/1419641#tabs-unfinished . My understanding is that the channel will update after no jobs remain in the queue, even if they will be cancelled.