Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibm-plex: init at 0.5.3 #32861

Merged
merged 1 commit into from Dec 24, 2017
Merged

ibm-plex: init at 0.5.3 #32861

merged 1 commit into from Dec 24, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 19, 2017

Motivation for this change

Add IBM Plex, IBM’s new corporate type family. IBM Plex is open source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I also packaged it (did not open a PR though) but yours look better.

@joachifm joachifm merged commit 395f2dd into NixOS:master Dec 24, 2017
@romildo romildo deleted the new.ibm-plex branch December 24, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @jtojnar @joachifm @GrahamcOfBorg