termite: add patch to fix handling nix urls #32862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you mention the pull request in the comment next to the patch? |
Patch based on: thestinger/termite#516 While this might "break" some URL's in the wild, in return this fixes matching of URL's in Nix code. Without this patch the trailing semicolon is included as part of the URL, which creates invalid URL's for nearly all meta.homepage values.
dtzWill
force-pushed
the
feature/termite-nix-urls
branch
from
0b3bddb
to
7736c9d
Compare
|
Good catch, added mention of the PR in the nix expression and patch file. |
|
@GrahamcOfBorg build termite |
There was a problem hiding this comment.
Success for system: aarch64-linux
shrinking RPATHs of ELF executables and libraries in /nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13
shrinking /nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13/bin/.termite-wrapped
gzipping man pages under /nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13/share/man/
stripping (with flags -S) in /nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13/bin
patching script interpreter paths in /nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13
checking for references to /build in /nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13...
shrinking RPATHs of ELF executables and libraries in /nix/store/f6v716r7h5mqbmjpsmnx6afy87dfv9mf-termite-13-terminfo
patching script interpreter paths in /nix/store/f6v716r7h5mqbmjpsmnx6afy87dfv9mf-termite-13-terminfo
checking for references to /build in /nix/store/f6v716r7h5mqbmjpsmnx6afy87dfv9mf-termite-13-terminfo...
/nix/store/z09d7gzpp3xhr5jqpa620z4wq5cwky7b-termite-13
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking RPATHs of ELF executables and libraries in /nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13
shrinking /nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13/bin/.termite-wrapped
gzipping man pages under /nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13/share/man/
stripping (with flags -S) in /nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13/bin
patching script interpreter paths in /nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13
checking for references to /tmp/nix-build-termite-13.drv-0 in /nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13...
shrinking RPATHs of ELF executables and libraries in /nix/store/3n0wwzdjazdds1a0rn092lphw6va9ssg-termite-13-terminfo
patching script interpreter paths in /nix/store/3n0wwzdjazdds1a0rn092lphw6va9ssg-termite-13-terminfo
checking for references to /tmp/nix-build-termite-13.drv-0 in /nix/store/3n0wwzdjazdds1a0rn092lphw6va9ssg-termite-13-terminfo...
/nix/store/rslax7svi9asrdxs76xm4ixa5zicggzl-termite-13
There was a problem hiding this comment.
Failure for system: x86_64-darwin
checking if clang++ -std=gnu++11 supports flag -Wstrict-null-sentinel in envvar CXXFLAGS... no
checking if clang++ -std=gnu++11 supports flag -fno-rtti in envvar CXXFLAGS... yes
checking if clang++ -std=gnu++11 supports flag -fno-exceptions in envvar CXXFLAGS... yes
checking if clang++ -std=gnu++11 supports flag -fvisibility=hidden in envvar CXXFLAGS... yes
checking if clang++ -std=gnu++11 supports flag -fvisibility-inlines-hidden in envvar CXXFLAGS... yes
checking if clang supports "-Wl,-Bsymbolic-functions" flag...
configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
builder for ‘/nix/store/qkw167nbgm7dd9kljw306mcvznbx1fnr-vte-ng-0.50.2.a.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/2m6wb4h3icn66ck9rf4r03psrg33sdbb-termite-13.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/2m6wb4h3icn66ck9rf4r03psrg33sdbb-termite-13.drv’ failed
|
How is that supposed to work? If I run |
|
Note that v13 also adds support for fancy hyperlinks, see: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda @jtojnar check your config, maybe? I thought the default was Mouse-over should underline and then be clickable (using |
|
Okay, creating |
8 tasks
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Builds on #32860 since patch is slightly different on v13 vs v12)
Motivation for this change
Nix-provided terminal shouldn't break on URL patterns commonly used in
*.nixfiles!This PR includes a patch addressing this.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Anecdotally: I've been using termite patched in this manner for months (tracking git, more or less) and I haven't experienced any problems.