Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time.timeZone: default to GMT #32868

Closed
wants to merge 1 commit into from
Closed

time.timeZone: default to GMT #32868

wants to merge 1 commit into from

Conversation

lukateras
Copy link
Member

Motivation for this change

This will fix #31393 while not changing behavior otherwise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member

Note that this does change the default behaviour where the value null means the timezone defaults to UTC and can be set imperatively using timedatectl. This was introduced in: a0d4640 by @lheckemann.

@lukateras
Copy link
Member Author

Thanks, then this is not an option.

@lukateras lukateras closed this Dec 20, 2017
@lukateras lukateras deleted the yegortimoshenko-patch-1 branch December 22, 2017 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Steam games like Stardew Valley fail to start when time.timeZone is not set
2 participants
@lukateras @basvandijk