Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/logcheck: replace rm with rm -r to delete the empty logcheck.logfiles.d/ #32562

Merged
merged 1 commit into from Dec 17, 2017
Merged

nixos/logcheck: replace rm with rm -r to delete the empty logcheck.logfiles.d/ #32562

merged 1 commit into from Dec 17, 2017

Conversation

phdoerfler
Copy link
Contributor

Motivation for this change

This is an attempt to fix #29906.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 11, 2017

@GrahamcOfBorg eval

@orivej orivej changed the title changed rm to rm -r in logcheck.nix nixos/logcheck: replace rm with rm -r to delete the empty logcheck.logfiles.d/ Dec 17, 2017
@orivej orivej merged commit cab7449 into NixOS:master Dec 17, 2017
@orivej
Copy link
Contributor

orivej commented Dec 17, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[17.03] Cannot use logcheck service
5 participants
@phdoerfler @grahamc @orivej @GrahamcOfBorg @Janik-Haag