Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blsd: init at unstable-2017-07-27 #32569

Merged
merged 1 commit into from Dec 19, 2017
Merged

blsd: init at unstable-2017-07-27 #32569

merged 1 commit into from Dec 19, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 11, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Dec 16, 2017

Are you still using blsd? (I know that you have posted this just 5 days ago.)

@magnetophon
Copy link
Member Author

magnetophon commented Dec 16, 2017 •
edited

It's a utility you don't need often, so tbh I've mostly tested it as opposed to used.
I do think it's a useful thing to have, assuming that's why you're asking.
Not super important though.

orivej
orivej reviewed Dec 16, 2017
View reviewed changes
pkgs/tools/misc/blsd/default.nix Outdated

buildGoPackage rec {
name = "blsd-${version}";
version = "unstable-2017-07-27";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version begins with a digit, so unstable is not part of the version, but the suffix of the name. (And for packages which are unlikely to ever have a version number it is fine to drop it.)

orivej
orivej reviewed Dec 16, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could have been handy for fzf as the author shows on the home page, but it lists directories not in sorted order which makes it feel unfinished and not something you'd want to use.

Nevertheless it's fine to merge. I've asked in case you've changed your mind, and because maintaining a dependent of libgit is not zero effort.

pkgs/tools/misc/blsd/default.nix Outdated
description = "List directories in breadth-first order";
license = licenses.mit;
platforms = platforms.unix;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please list maintainers.

@magnetophon
Copy link
Member Author

magnetophon commented Dec 19, 2017 •
edited

@orivej
Yeah, it's for fzf. I fixed your concerns.
If it really turns out a pain to maintain, I might drop it in the future, so if that's a reason not to merge, I understand.

@orivej
Copy link
Contributor

orivej commented Dec 19, 2017

@GrahamcOfBorg eval

@orivej orivej merged commit d045d62 into NixOS:master Dec 19, 2017
@magnetophon magnetophon deleted the blsd branch December 20, 2017 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @orivej @GrahamcOfBorg