handle undefined values more gracefully

mojolicious · Mar 17, 2016 · cf9d51c · cf9d51c
1 parent 89c78b2
commit cf9d51c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/Mojolicious/Validator.pm b/lib/Mojolicious/Validator.pm
@@ -40,7 +40,7 @@ sub _size {
   return $len < $min || $len > $max;
 }
 
-sub _trim { trim $_[2] }
+sub _trim { trim $_[2] // '' }
 
 1;
 

diff --git a/t/mojolicious/validation_lite_app.t b/t/mojolicious/validation_lite_app.t
@@ -184,11 +184,13 @@ is_deeply $validation->output, {foo => 'bar'}, 'right result';
 ok !$validation->optional('missing', 'trim')->is_valid, 'not valid';
 ok $validation->optional('baz', 'trim')->like(qr/^\d$/)->is_valid, 'valid';
 is_deeply $validation->output, {foo => 'bar', baz => [0, 1]}, 'right result';
-$validation = $t->app->validation->input({nothing => '  '});
+$validation = $t->app->validation->input({nothing => '  ', more => [undef]});
 ok !$validation->required('nothing', 'trim')->is_valid, 'not valid';
 is_deeply $validation->output, {}, 'right result';
 ok $validation->required('nothing')->is_valid, 'valid';
 is_deeply $validation->output, {nothing => '  '}, 'right result';
+ok !$validation->optional('more', 'trim')->is_valid, 'not valid';
+is_deeply $validation->output, {nothing => '  '}, 'right result';
 
 # Custom filter
 $t->app->validator->add_filter(quote => sub {qq{$_[1]="$_[2]"}});